fixes #544: split_flows.py: tiny split reaches caused by mismat… #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y mismatch of flowline and lake polygon
|
@hohe12ly Could you please request that this PR be merged into the |
|
@BrianAvant-NOAA Please check this out if you are interested |
|
We should also note this for FIM v4.X. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the new algorithm uses GeoPandas overlay with
identitymethod to create splits. then these splits are ordered by lake IDs. a subsequence that goes in and out of a lake multiple times is modified to have at most three parts: the one going into the late, the one in the lake, and the one out of the lake. the new algorithm returns such splits as a GeoDataFrame for the next step 1.5km length-based splitting. That length-based splitting is unchanged.Also, added one step after HUC8 overlay to remove empty geometries.