Drown using namespace std
#603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilMiller
force-pushed
the
phil/using-namespace-std
branch
from
d48619b to
f733af6
Compare
mattw-nws
force-pushed
the
phil/using-namespace-std
branch
2 times, most recently
from
5e1a86a to
4b64797
Compare
|
@PhilMiller when you get back, please look over this. I attempted to rebase it but ended up having to add quite a few additional changes to get it to compile again... I'm not sure if I lost a commit somehow in the rebase or what. Perhaps compare with your local repo copy. |
PhilMiller
commented
Aug 17, 2023
|
I don't see any commits missing, and the changes all look fine to me. I'm rebasing to |
Conflicts: include/realizations/catchment/Bmi_Module_Formulation.hpp (Removed `check_internal_providers` method dropped in NOAA-OWP#599 - @mattw-nws )
..that were missing somehow? Did these get dropped somehow when I rebased on master? Squash these with the `Abominate...` commit??
PhilMiller
force-pushed
the
phil/using-namespace-std
branch
from
4b64797 to
05b1afc
Compare
mattw-nws
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
using namespace stdis poor practice. Clean it out of the code base, other than instances in zombie code that's being deleted.Additions
Removals
using namespace stdNotes
Instances in zombie code were left alone
Todos
Checklist