Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symlink data directories into build directories #691

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

program--
Copy link
Contributor

@program-- program-- commented Dec 26, 2023

This PR adds symlinks to the data/ and test/data/ directories in out-of-source build directories. This is done through CMake's file(CREATE_LINK ...) command.

Additions

  • file() call to symlink <root>/data -> <build>/data
  • file() call to symlink <root>/test/data -> <build>/test/data

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Target Environment support

  • Linux
  • macOS

@program-- program-- added the build Issues related to CMake and building ngen label Dec 26, 2023
@program-- program-- requested a review from PhilMiller December 26, 2023 20:25
@program-- program-- self-assigned this Dec 26, 2023
Copy link
Contributor

@PhilMiller PhilMiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reduces the test failures I see in an out-of-tree build.

There's still other failures, but those can be addressed separately:

Can't init test_bmi_cpp; unreadable shared library file '{{EXTERN_LIB_DIR_PATH}}libtestbmicppmodel'

@PhilMiller
Copy link
Contributor

(edited description to reflect my testing on macOS)

@PhilMiller PhilMiller merged commit df7e9b5 into NOAA-OWP:master Dec 27, 2023
19 checks passed
@program-- program-- deleted the jsm-test-data-symlink branch December 27, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to CMake and building ngen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants