Skip to content

Conversation

@b-barton
Copy link
Collaborator

@b-barton b-barton commented Jun 6, 2025

There were warning messages coming up about not using "is not" for some of the comparisons, also a warning about divide by zero in the chunk function. Issue #208
The warnings have been fixed.

@b-barton b-barton requested a review from jdha June 6, 2025 14:12
@b-barton b-barton self-assigned this Jun 6, 2025
@b-barton b-barton added the bug Something isn't working label Jun 6, 2025
@b-barton b-barton linked an issue Jun 6, 2025 that may be closed by this pull request
@b-barton b-barton changed the base branch from master to 205-bottom-zeros June 6, 2025 14:13
@b-barton b-barton marked this pull request as draft June 6, 2025 14:17
@b-barton b-barton changed the title 208 warnings 208 warnings and performance Jun 12, 2025
jdha
jdha previously approved these changes Jun 27, 2025
@b-barton b-barton changed the base branch from 205-bottom-zeros to master June 27, 2025 12:56
@b-barton b-barton dismissed jdha’s stale review June 27, 2025 12:56

The base branch was changed.

@b-barton b-barton marked this pull request as ready for review June 27, 2025 12:56
@jdha jdha self-requested a review June 27, 2025 12:59
@b-barton b-barton merged commit ea3e07d into master Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix warning messages and improve processing time for India Model

3 participants