#216 Bug where velocity sometimes has NaNs in bottom level #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ided to user input in the namelist and checking the netcdf file.
jdha
approved these changes
Sep 16, 2025
jdha
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As issue #216 says there were places where a sigma grid had nans in the layer above the bottom. The problem was that the type of vertical coordinates of the parent and child grids was incorrectly being interpreted as zps instead of sco.
To fix this, I have changed the namelist to include user specified zgr type definition. I have also added code that tries to read ln_zco, ln_zps and ln_sco from the domain file and compares with the user defined zgr type. This fixes #216.