Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BuildResidentialHPXML measure: Shared recirculation #1310

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

joseph-robertson
Copy link
Collaborator

@joseph-robertson joseph-robertson commented Mar 8, 2023

Pull Request Description

Closes #1308.

Adds a new optional hot_water_distribution_recirc_num_bedrooms_served argument to BuildResHPXML. When greater than the number of bedrooms in the modeled dwelling unit (and system type is recirculation), a shared recirculation system is populated. Shared control type and pump power are assigned values from the existing control type and pump power arguments.

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (via tasks.rb)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests and/or workflow/tests/hpxml_translator_test.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@joseph-robertson joseph-robertson self-assigned this Mar 8, 2023
@joseph-robertson joseph-robertson marked this pull request as ready for review March 9, 2023 00:36
@shorowit shorowit added the enhancement New feature or request label Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

BuildResidentialHPXML measure: Shared recirculation
2 participants