Manufactured home belly ducts #1340
Conversation
|
@shorowit This is just a start, but I wanted to check in with you that I'm on correct path here. |
There was a problem hiding this comment.
Looks like a reasonable start. That may be all you have to do to handle the ducts, but you'll obviously have to make some additional changes to handle the belly/wing foundation type. I'd suggest manually creating an HPXML for testing -- you'll probably hit errors or, if it runs correctly, it'll probably have some wrong IDF properties. To be able to run the HPXML file, you'll at a minimum need to update the schematron (EPvalidator.xml) to allow a belly and wing foundation type and duct location.
[skip ci]
…o mobile_home_belly_ducts # Conflicts: # BuildResidentialHPXML/measure.xml # HPXMLtoOpenStudio/measure.xml # ReportUtilityBills/measure.xml # workflow/sample_files/base-appliances-dehumidifier-ief-portable.xml # workflow/sample_files/base-appliances-dehumidifier-ief-whole-home.xml # workflow/sample_files/base-appliances-dehumidifier-multiple.xml # workflow/sample_files/base-appliances-dehumidifier.xml # workflow/sample_files/base-atticroof-radiant-barrier.xml # workflow/sample_files/base-enclosure-2stories-garage.xml # workflow/sample_files/base-enclosure-garage.xml # workflow/sample_files/base-enclosure-split-level.xml # workflow/sample_files/base-foundation-basement-garage.xml # workflow/sample_files/base-foundation-complex.xml # workflow/sample_files/base-foundation-slab.xml # workflow/sample_files/base-foundation-walkout-basement.xml # workflow/sample_files/base-hvac-none.xml # workflow/sample_files/base-location-dallas-tx.xml # workflow/sample_files/base-location-honolulu-hi.xml # workflow/sample_files/base-location-miami-fl.xml # workflow/sample_files/base-location-phoenix-az.xml # workflow/sample_files/base-pv-battery-garage.xml # workflow/tests/base_results/results.csv # workflow/tests/base_results/results_bills.csv
Co-authored-by: Scott Horowitz <[email protected]>
…o mobile_home_belly_ducts # Conflicts: # Changelog.md # HPXMLtoOpenStudio/measure.xml
…o mobile_home_belly_ducts
…o mobile_home_belly_ducts
There was a problem hiding this comment.
I fixed the line endings (so that we don't have 350 HPXML files w/ diffs in GitHub, now or in the future) and found one more place where we needed to remove code for setting the water heater location to the belly.
This looks good to me. Will merge in if the CI comes back happy. Thanks, @nmerket!
Pull Request Description
Adding mobile home belly and wing and ducts in the belly.
Checklist
PR Author: Check these when they're done. Not all may apply.
strikethroughand check any that do not apply.PR Reviewer: Verify each has been completed.
EPvalidator.xml) has been updatedtasks.rb)HPXMLtoOpenStudio/testsand/orworkflow/tests/hpxml_translator_test.rb)openstudio tasks.rb update_measureshas been run