Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conditioned basement slab insulation error #1431

Merged
merged 3 commits into from
Jul 11, 2023

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Jul 11, 2023

Pull Request Description

Closes #1430.

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (via tasks.rb)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests and/or workflow/tests/hpxml_translator_test.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit self-assigned this Jul 11, 2023
@shorowit shorowit marked this pull request as ready for review July 11, 2023 14:52
@shorowit shorowit merged commit 1f113e8 into master Jul 11, 2023
@shorowit shorowit deleted the bugfix-cond-basement-full-slab-ins branch July 11, 2023 16:02
@joseph-robertson joseph-robertson mentioned this pull request Jul 17, 2023
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error if conditioned basement with fully spanning slab insulation
1 participant