Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unmet water heater loads EMS program #1502

Open
wants to merge 97 commits into
base: master
Choose a base branch
from
Open

Commits on Oct 4, 2023

  1. Configuration menu
    Copy the full SHA
    6335d24 View commit details
    Browse the repository at this point in the history
  2. busted by rubocop :)

    jmaguire1 committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    e70d0e9 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Configuration menu
    Copy the full SHA
    23381f8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ddc558c View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Configuration menu
    Copy the full SHA
    dffe6f6 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Configuration menu
    Copy the full SHA
    92c0e97 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4aa4a0c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ec8cef2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9d3b025 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Still in progress, but: working on restructuring the calculation base…

    …d on some discussions with Joe. Still need to connect the EMS sensor for WH outlet temperature.
    jmaguire1 committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    7658e4f View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Configuration menu
    Copy the full SHA
    6a8b015 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    44c4c61 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c59eaec View commit details
    Browse the repository at this point in the history
  4. Fix some typos

    jmaguire1 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    6d68919 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Configuration menu
    Copy the full SHA
    a58dcbf View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Configuration menu
    Copy the full SHA
    04b94ad View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. Configuration menu
    Copy the full SHA
    227138e View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Configuration menu
    Copy the full SHA
    e250890 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    caae214 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Configuration menu
    Copy the full SHA
    2bae66b View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Configuration menu
    Copy the full SHA
    3044382 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0379ace View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    70a9868 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Configuration menu
    Copy the full SHA
    015383e View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

    …o unmet_wh_loads.
    
    Attempt #1 at fixing all the conflicts
    jmaguire1 committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    a58ada4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6421080 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Configuration menu
    Copy the full SHA
    c4239f0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    258c28f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    921a0f0 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Some fixes for unmet showers with multiple WHs.

    Still need to develop a few new test cases (since unmet loads is basically always expected to be 0 with smooth profiles, and that's especially true with multiple WHs) and do some testing for 2 tank SHWs (to exclude calculating unmet showers from the storage tank before the backup WH)
    jmaguire1 committed May 28, 2024
    Configuration menu
    Copy the full SHA
    dc3a752 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Clean up EMS a bit, change hot water usage be 0 during outages (helps…

    … with testing, and technically more correct, even though there's no energy impact to draws when the WH is off)
    jmaguire1 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    d513cf4 View commit details
    Browse the repository at this point in the history
  2. This should actually exclude solar storage tanks from 2 tank systems,…

    … but there's probably a more elegant way to do it.
    jmaguire1 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    309714c View commit details
    Browse the repository at this point in the history
  3. Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

    …o unmet_wh_loads
    
    # Conflicts:
    #	HPXMLtoOpenStudio/resources/constants.rb
    #	HPXMLtoOpenStudio/resources/hotwater_appliances.rb
    #	HPXMLtoOpenStudio/resources/output.rb
    #	HPXMLtoOpenStudio/resources/schedules.rb
    #	ReportSimulationOutput/measure.rb
    shorowit committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    8ed29e1 View commit details
    Browse the repository at this point in the history
  4. Bugfix.

    shorowit committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    1641ec1 View commit details
    Browse the repository at this point in the history
  5. tasks.rb update_hpxmls

    shorowit committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    6e63c6c View commit details
    Browse the repository at this point in the history
  6. Some more fixes/cleanup.

    shorowit committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    ca76f23 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Configuration menu
    Copy the full SHA
    11d46ea View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6b630e8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    47a60a4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b22a027 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    51dbd2e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    32fdfdd View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6def768 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f0d68ea View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    7e939bc View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    1daadab View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    1737481 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    f28fceb View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    44a980a View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    e6b6ee0 View commit details
    Browse the repository at this point in the history
  15. Latest results.

    GitHub Action committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    7d96e30 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    e36fd4e View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    3b38d32 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Configuration menu
    Copy the full SHA
    b55a993 View commit details
    Browse the repository at this point in the history
  2. Latest results.

    GitHub Action committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    d8f0bc2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    20449e9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    624bfd6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e572c5f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f75b4e3 View commit details
    Browse the repository at this point in the history
  7. Typo.

    joseph-robertson committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    0fee44d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4a7a1d1 View commit details
    Browse the repository at this point in the history
  9. Latest results.

    GitHub Action committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    bb41452 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Change shower draws to be a % of fixtures (if smooth profiles) based …

    …on Scott's message.
    
    Update unmet load program to work for any timestep and fix units issue.
    jmaguire1 committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    b0ad6ab View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

    …o unmet_wh_loads
    
    # Conflicts:
    #	Changelog.md
    #	HPXMLtoOpenStudio/measure.xml
    #	workflow/tests/base_results/results_simulations_bills.csv
    #	workflow/tests/base_results/results_simulations_energy.csv
    #	workflow/tests/base_results/results_simulations_hvac.csv
    #	workflow/tests/base_results/results_simulations_loads.csv
    #	workflow/tests/base_results/results_simulations_misc.csv
    shorowit committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    d70bbe1 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Configuration menu
    Copy the full SHA
    3d506df View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    593d488 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c5e21b8 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Configuration menu
    Copy the full SHA
    992fdb2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a0288de View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    169617f View commit details
    Browse the repository at this point in the history
  4. Latest results.

    GitHub Action committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    5f5cc93 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Configuration menu
    Copy the full SHA
    45b6200 View commit details
    Browse the repository at this point in the history
  2. Latest results.

    GitHub Action committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    6f364b1 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Configuration menu
    Copy the full SHA
    2177b8a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0c8732a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    966f0b8 View commit details
    Browse the repository at this point in the history
  4. Go back to more generic unmet loads program (rather than unmet shower…

    … loads program). We could potentially have other unmet loads in the future in this program, and outputs are already pretty explicitly labeled as shower related.
    jmaguire1 committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    354360a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    773ae8b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7c878ea View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Configuration menu
    Copy the full SHA
    41105c5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1a905c7 View commit details
    Browse the repository at this point in the history
  3. Latest results.

    GitHub Action committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    a529822 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

    …o unmet_wh_loads
    
    # Conflicts:
    #	BuildResidentialScheduleFile/measure.xml
    #	HPXMLtoOpenStudio/measure.rb
    #	HPXMLtoOpenStudio/measure.xml
    #	HPXMLtoOpenStudio/resources/data/unavailable_periods.csv
    #	HPXMLtoOpenStudio/resources/hotwater_appliances.rb
    #	workflow/tests/base_results/results_simulations_misc.csv
    shorowit committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    9cccccf View commit details
    Browse the repository at this point in the history
  2. Latest results.

    GitHub Action committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    85145ed View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

    …o unmet_wh_loads
    
    # Conflicts:
    #	HPXMLtoOpenStudio/measure.xml
    #	workflow/tests/base_results/results_simulations_misc.csv
    #	workflow/tests/util.rb
    shorowit committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    2b5c158 View commit details
    Browse the repository at this point in the history
  2. Latest results.

    GitHub Action committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    cb8ecd8 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Configuration menu
    Copy the full SHA
    2aff460 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    442bd58 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Configuration menu
    Copy the full SHA
    07c650b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6bc29d5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    82e0153 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    42169b2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    afadd97 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d1db089 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    0a7ba8a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1224612 View commit details
    Browse the repository at this point in the history
  9. Latest results.

    GitHub Action committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    52e9681 View commit details
    Browse the repository at this point in the history