-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model EV Batteries #1533
base: master
Are you sure you want to change the base?
Model EV Batteries #1533
Conversation
…o ev_batteries # Conflicts: # BuildResidentialHPXML/measure.rb # HPXMLtoOpenStudio/resources/battery.rb # HPXMLtoOpenStudio/resources/hpxml_defaults.rb
… into ev_batteries
Yes, for now we plan to limit to 1 EV/unit. However, the current implementation does allow for one home battery and one EV battery and expects separate schedules for each. |
I assume that probably won't work, for the same reason that modeling two home batteries wasn't previously supported. But we can worry about that later. More of a heads up for now. |
… into ev_batteries
…scharge power for reporting
After some discussions regarding why we do not model two home batteries, I believe it has to do with how we would associate them with an ELCD (PV system). For EVs, I ensure a new ELCD (non-PV) (b1ef026) is created and references the EV battery, so I think it should be possible to include both EVs and home batteries. |
… as needed; expose fuel economy and vehicle miles traveled args
…ctive discharge power
@aspeake You should really run |
Pull Request Description
Allows a new battery object specific to EVs. Implemented in a way such that it could eventually support bidirectional charging, but not included in this PR.
Companion HPXML PR: hpxmlwg/hpxml#403
Checklist
PR Author: Check these when they're done. Not all may apply.
strikethroughand check any that do not apply.PR Reviewer: Verify each has been completed.
EPvalidator.xml
) has been updatedtasks.rb
)HPXMLtoOpenStudio/tests
and/orworkflow/tests/hpxml_translator_test.rb
)openstudio tasks.rb update_measures
has been run