Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Bob Ross Residence test cases - Del4&5 #1827

Merged
merged 7 commits into from
Sep 16, 2024
Merged

Conversation

yzhou601
Copy link
Collaborator

@yzhou601 yzhou601 commented Sep 9, 2024

Pull Request Description

[description here]

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@yzhou601 yzhou601 self-assigned this Sep 9, 2024
@yzhou601 yzhou601 changed the base branch from master to more_bob_ross_cases September 9, 2024 22:13
Base automatically changed from more_bob_ross_cases to master September 10, 2024 22:42
@shorowit shorowit marked this pull request as ready for review September 16, 2024 16:59
Copy link
Contributor

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed to be good. Will merge once CI finishes.

@shorowit shorowit merged commit 59b6bd2 into master Sep 16, 2024
@shorowit shorowit deleted the Bob_Ross_del_4_5 branch September 16, 2024 19:34
@joseph-robertson joseph-robertson mentioned this pull request Sep 17, 2024
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants