Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mech Vent Preconditioning - Loads #753

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Mech Vent Preconditioning - Loads #753

wants to merge 17 commits into from

Conversation

yzhou601
Copy link
Collaborator

@yzhou601 yzhou601 commented May 5, 2021 •
edited by shorowit
Loading

Pull Request Description

Loads adjustment to close #750

Checklist

Not all may apply:

  • EPvalidator.xml has been updated
  • Tests (and test files) have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI (checked comparison artifacts)

@yzhou601 yzhou601 self-assigned this May 5, 2021
@yzhou601
Copy link
Collaborator Author

yzhou601 commented May 5, 2021

@shorowit
Change the preconditioning to the setpoints instead of room ac helped reduce preconditioning energy by more than 20%, and cut the difference of heating energy sum by about half:

  Preheating Energy(MBtu) Heating Energy(MBtu) Sum(MBtu) Cooling load(MBtu)
shared-vent 0 8.6 8.6 4.73
shared-vent-precond(Before) 16.61 0.53 17.14 7.56
shared-vent-precond(pre-conditioned to heating setpoint) 12.65 0.71 13.36 5.58

I found there's a significant amount of preheating energy consumed in summer, using heating setpoint to determine the preheating can help in that case, but cannot eliminate. This means in the summer, whenever outdoor air temperature falls below 20C, preheating will still work to heat it to 20C, this also caused cooling loads increased due to the loss of free cooling. It is hard to determine whether to allow the cool air into the space by simple logic. So this makes me curious about the real-world preheating, will it be smart enough to know whether the cool air can serve as free cooling? Or will it just be disabled in summer?

Before:
image
After:
image

@yzhou601
Copy link
Collaborator Author

yzhou601 commented May 5, 2021

If eliminating the discrepancy in all the summer points (where heating energy = 0 in shared-vent.xml), the heating energy difference will be as small as 0.615MBtu on this branch, and 1.546MBtu on master.

@yzhou601
Copy link
Collaborator Author

yzhou601 commented May 5, 2021

The shared-vent.xml results changed a bit due to bringing the latest master (os-320). See below the results adding seasonal availability.

  Preheating Energy(MBtu) Heating Energy(MBtu) Sum(MBtu) Cooling load(MBtu)
shared-vent.xml 0 8.56 8.56 4.65
shared-vent-precond.xml(pre-conditioned to heating setpoint+season) 10.4 1.2 11.6 5.12
Diff 10.4 -7.36 3.04 0.47
Diff % 100% -86.0% 35.5% 10.1%

@shorowit
Copy link
Contributor

shorowit commented May 6, 2021

@yzhou601 Nice. I think the current control strategy is a reasonable balance. I also pulled this branch into OS-ERI and tested it on the original file sent to us:

Case ERI
Shared MV, no precond 51.6
Shared MV, yes precond (orig) 57.8
Shared MV, yes precond (revised) 53.4

So that seems pretty consistent with your results.

I have sent these results to our user for feedback. In the meantime, it'd be great if you could look into implementing the change to the heating/cooling loads (and component loads?) to remove the effect of preconditioning equipment.

shorowit added a commit to NREL/OpenStudio-ERI that referenced this pull request May 11, 2021
@shorowit
Revises preconditioning algorithm based on NREL/OpenStudio-HPXML#753
28756d2
shorowit added a commit to NREL/OpenStudio-ERI that referenced this pull request May 11, 2021
@shorowit
Revises preconditioning algorithm based on NREL/OpenStudio-HPXML#753
58bcadf
@yzhou601 yzhou601 requested a review from shorowit May 13, 2021 19:22
@yzhou601 yzhou601 marked this pull request as ready for review May 13, 2021 19:22
yzhou601
yzhou601 commented May 13, 2021
View reviewed changes
Copy link
Collaborator Author

@yzhou601 yzhou601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shorowit This PR is ready for review. The load reporting changes are reflected on ci comparison. Only base-bldgtype-multifamily-shared-mechvent-multiple.xml and base-bldgtype-multifamily-shared-mechvent-preconditioning.xml show result diffs. And those diffs look good to me.

HPXMLtoOpenStudio/measure.rb
@@ -2138,14 +2138,25 @@ def self.add_total_loads_output(runner, model, living_zone)
program.setName(Constants.ObjectNameTotalLoadsProgram)
program.addLine('Set loads_htg_tot = 0')
program.addLine('Set loads_clg_tot = 0')
# Need to adjust E+ EnergyTransfer meters for mech vent preconditioning
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjust total loads read from E+ output meter

HPXMLtoOpenStudio/measure.rb
@@ -2516,6 +2527,15 @@ def self.add_component_loads_output(runner, model, living_zone, liv_load_sensors
mechvent_sensors.each do |sensor|
program.addLine("Set hr_mechvent = hr_mechvent - #{sensor.name}")
end
# Adjust component load reporting for preconditioning
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjust component loads read from equipment objects (add preconditioning loads to mechvent subitem).

HPXMLtoOpenStudio/resources/airflow.rb Outdated
else
infil_program.addLine('Set FanTotalToLv = Fan_MFR * (OASupInEnth - ZoneAirEnth)')
infil_program.addLine('Set FanSensToLv = Fan_MFR * ZoneCp * (OASupInTemp - ZoneTemp)')
infil_program.addLine('Set FanLatToLv = FanTotalToLv - FanSensToLv')
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cleanups here. Also enable a single outlet temperature variable(ZoneInTemp here, any better name?) for preconditioning calculation.

HPXMLtoOpenStudio/resources/airflow.rb
htg_energy_actuator = create_other_equipment_object_and_actuator(model: model, name: "shared mech vent preheating energy #{i}", space: @living_space, frac_lat: 0.0, frac_lost: 1.0, hpxml_fuel_type: f_preheat.preheating_fuel, end_use: Constants.ObjectNameMechanicalVentilationPreconditioning)
htg_load_var = OpenStudio::Model::EnergyManagementSystemGlobalVariable.new(model, "Precond_HeatingLoad_#{i}")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Global variables created here for load reporting.

@shorowit shorowit changed the title Mech Vent Preconditioning Mech Vent Preconditioning - Loads May 14, 2021
shorowit added a commit that referenced this pull request May 14, 2021
@shorowit
Code changes from #753, energy impact only.
a2c4fb5
@shorowit shorowit mentioned this pull request May 14, 2021
Merged
6 tasks
@shorowit shorowit changed the base branch from master to mech_vent_precond_energy_only May 14, 2021 18:26
@shorowit
Merge branch 'mech_vent_precond_energy_only' of https://github.com/NR…
f08f747 
…EL/OpenStudio-HPXML into mech_vent_precond

# Conflicts:
#	HPXMLtoOpenStudio/resources/airflow.rb
Base automatically changed from mech_vent_precond_energy_only to master May 14, 2021 19:21
@shorowit
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
87d7574 
…o mech_vent_precond

# Conflicts:
#	HPXMLtoOpenStudio/resources/airflow.rb
#	workflow/tests/base_results/results.csv
shorowit added a commit to NREL/OpenStudio-ERI that referenced this pull request May 18, 2021
@shorowit
Squashed 'hpxml-measures/' changes from 4e35921a1..fc8b4d312
b05a24c 
fc8b4d312 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into gshp-installation-quality
713e829aa Removes IsPackagedSystem since split systems can still have pre-charged line sets. We'll just assume that if someone is providing a non-zero value, it makes sense for their system type. Added some documentation to clarify.
fc08a1433 Merge pull request #765 from NREL/default_vent_fan_power
c0b0d06a4 Latest results.
8e56249cd Allows defaulting of mechanical ventilation fan power (by type).
e6e5c15e2 Merge pull request #674 from NREL/hvac_dhw_default_efficiencies
08db7a78c Update Changelog.md
47c8de4a6 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
7befb82d2 Update projects
3df7ce7b0 Latest results.
c4228096c update the default efficiency of the electric type heating systems
17f6ebc69 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
1f8403e4f Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into gshp-installation-quality
f53765eff Merge pull request #763 from NREL/mech_vent_precond_energy_only
3ce2810d6 Latest results.
a2c4fb5dd Code changes from NREL/OpenStudio-HPXML#753, energy impact only.
5cac9dbd2 address comments
c8872d6cb Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
95409f512 address comments
f6f88ca30 Merge pull request #761 from NREL/seasons_followup
4c8870a3c Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
ce4298508 doc update
824d6959e add invalid test
31901ae87 Update Changelog.md
87144acba Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into gshp-installation-quality
3cdc84532 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
6e5f10028 fix test_fireplaces
183acefa2 update test_defaults
fe1e69a8b Merge branch 'hvac_dhw_default_efficiencies' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
ecae4c26e Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
dd56e58a7 update fireplace/stove efficiency defaulting
19e7ad5b0 Latest results.
3a69e9432 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into gshp-installation-quality
276f9403e Latest results.
8601281b4 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
391100932 Latest results.
6d0c3755a Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
277d71c55 cleanup + fix
7a55ea4b0 Merge branch 'gshp-installation-quality' of https://github.com/NREL/OpenStudio-HPXML into gshp-installation-quality
d50bdd14e cleanup
440f6eecc cleanup for heating hvacsizing method
a274d8ef9 Latest results.
7a20077d2 One more.
5f2a4b862 Manually fix code that was previously accidentally reverted.
cb9962ec3 Merge branch 'os_v320' of https://github.com/NREL/OpenStudio-HPXML into gshp-installation-quality
7b8bb7ca9 Merge branch 'os_v320' of https://github.com/NREL/OpenStudio-HPXML into gshp-installation-quality
4976c3dcf Merge branch 'os_v320' of https://github.com/NREL/OpenStudio-HPXML into gshp-installation-quality
544a15ad3 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
beefde88b update documentation
4948ed5ed Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
fc1faeb7f coarse efficiency defaulting for fireplace/stove Use energyplus.rb for fuel type mapping
a8f7a9304 revert merging
814183b01 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into gshp-installation-quality
0e94275b4 Add configuration of packaged system with 0 charge defect for schematron test
ca2a92b9d Merge branch 'os_v320' of https://github.com/NREL/OpenStudio-HPXML into gshp-installation-quality
f7fb92967 delete repeating rule
6f9f06da1 only gshp to use is_packaged_system
0ab14df13 fix validator.
53b1794cf update test file multiple
5cb9bd19e Add packaged system element
c3a067621 Add test for gshp iq
a531df874 Merge branch 'os_v320' of https://github.com/NREL/OpenStudio-HPXML into gshp-installation-quality
370299fbc Latest results.
09efbc4f0 Merge branch 'os_v320' of https://github.com/NREL/OpenStudio-HPXML into gshp-installation-quality
05c5934a4 Latest results.
48da5c831 Merge branch 'hvac_dhw_default_efficiencies' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
b9d4fd4e2 code cleanup and add more tests
4ca0de478 Latest results.
bb4e92346 fix test_furnaces
4e2f3ab4c Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
a25e7204c Merge branch 'os_v320' of https://github.com/NREL/OpenStudio-HPXML into gshp-installation-quality
72ed16096 Added clarification to the docs about packaged vs split GSHPs systems. (Also updated it to remove the "zero only" limitation while I'm in there.)
cdc0bc802 add charge defect ratio to gshp
ee5afad48 fix base-misc-defaults.xml
631235b16 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
4bdbd77d3 pick up the rest of the initial comments
2255a1a29 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
3ad035b7e pick up some of the initial comments
21d7ecb8e another documentation update
f6c4f7c3d update documentation
f0e0c56b5 revert assertions for tankless and heatpump water heaters
8a0d1acd3 remove Fixmes
072c0f2ea Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
5955f3ea8 update hpxml for water heaters and change the assertions for water heater efficiencies
0728f7a1f update EPvalidator for water heating systems
861ef8a7b Bugfix and update EPvalidator.xml and hpxml.rb
8bf095e75 update test_defaults
2b0fe12a1 run tasks.rb
fdc7aadff Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
6a477f99a Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
2e5032654 first pass

git-subtree-dir: hpxml-measures
git-subtree-split: fc8b4d312064b04e852a861f7a41feeadeac8dd8
shorowit added a commit to NREL/OpenStudio-ERI that referenced this pull request May 19, 2021
@shorowit
Squashed 'hpxml-measures/' changes from 4e35921a1..862d05663
6deec8d 
862d05663 Minor docs update.
fc08a1433 Merge pull request #765 from NREL/default_vent_fan_power
c0b0d06a4 Latest results.
8e56249cd Allows defaulting of mechanical ventilation fan power (by type).
e6e5c15e2 Merge pull request #674 from NREL/hvac_dhw_default_efficiencies
08db7a78c Update Changelog.md
47c8de4a6 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
7befb82d2 Update projects
3df7ce7b0 Latest results.
c4228096c update the default efficiency of the electric type heating systems
17f6ebc69 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
f53765eff Merge pull request #763 from NREL/mech_vent_precond_energy_only
3ce2810d6 Latest results.
a2c4fb5dd Code changes from NREL/OpenStudio-HPXML#753, energy impact only.
c8872d6cb Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
95409f512 address comments
f6f88ca30 Merge pull request #761 from NREL/seasons_followup
4c8870a3c Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
3cdc84532 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
6e5f10028 fix test_fireplaces
183acefa2 update test_defaults
fe1e69a8b Merge branch 'hvac_dhw_default_efficiencies' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
ecae4c26e Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
dd56e58a7 update fireplace/stove efficiency defaulting
276f9403e Latest results.
8601281b4 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
391100932 Latest results.
6d0c3755a Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
544a15ad3 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
beefde88b update documentation
4948ed5ed Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
fc1faeb7f coarse efficiency defaulting for fireplace/stove Use energyplus.rb for fuel type mapping
48da5c831 Merge branch 'hvac_dhw_default_efficiencies' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
b9d4fd4e2 code cleanup and add more tests
4ca0de478 Latest results.
bb4e92346 fix test_furnaces
4e2f3ab4c Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
ee5afad48 fix base-misc-defaults.xml
631235b16 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
4bdbd77d3 pick up the rest of the initial comments
2255a1a29 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
3ad035b7e pick up some of the initial comments
21d7ecb8e another documentation update
f6c4f7c3d update documentation
f0e0c56b5 revert assertions for tankless and heatpump water heaters
8a0d1acd3 remove Fixmes
072c0f2ea Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
5955f3ea8 update hpxml for water heaters and change the assertions for water heater efficiencies
0728f7a1f update EPvalidator for water heating systems
861ef8a7b Bugfix and update EPvalidator.xml and hpxml.rb
8bf095e75 update test_defaults
2b0fe12a1 run tasks.rb
fdc7aadff Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
6a477f99a Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
2e5032654 first pass

git-subtree-dir: hpxml-measures
git-subtree-split: 862d056638eb1df40cc0e2eb7be60cf1e5210a96
joseph-robertson added a commit to NREL/resstock that referenced this pull request May 19, 2021
@joseph-robertson
Squashed 'resources/hpxml-measures/' changes from 97db672b423..cd54d0…
8d142bf 
…3eff4

cd54d03eff4 Adjustments to test osws and mech vent args.
3e3ee5719cc Merge branch 'master' into build-res-hpxml-v3
fc08a1433f8 Merge pull request #765 from NREL/default_vent_fan_power
c0b0d06a486 Latest results.
8e56249cd3f Allows defaulting of mechanical ventilation fan power (by type).
e6e5c15e288 Merge pull request #674 from NREL/hvac_dhw_default_efficiencies
08db7a78c6c Update Changelog.md
47c8de4a6e9 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
7befb82d26c Update projects
3df7ce7b064 Latest results.
c4228096c63 update the default efficiency of the electric type heating systems
17f6ebc6982 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
f53765eff2b Merge pull request #763 from NREL/mech_vent_precond_energy_only
3ce2810d6ac Latest results.
a2c4fb5ddbd Code changes from NREL/OpenStudio-HPXML#753, energy impact only.
de6fe7c07e9 Merge branch 'master' into build-res-hpxml-v3
c8872d6cb76 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
95409f512f6 address comments
f6f88ca30cf Merge pull request #761 from NREL/seasons_followup
045d8b4f6f4 Merge branch 'master' into build-res-hpxml-v3
4e35921a14d Fix base-multiple-buildings.xml to be valid.
896a53ea590 Fix order of HPXML elements. Add nokogiri schema validation to CI tests.
1a601c92fc0 Delete file.
355a40ae7f5 update xml
f4b5d2aad20 Removes error-check for number of bedrooms based on conditioned floor area, per RESNET guidance.
4c8870a3ca1 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
3cdc84532b3 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
6e5f10028ed fix test_fireplaces
183acefa2d2 update test_defaults
fe1e69a8b03 Merge branch 'hvac_dhw_default_efficiencies' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
ecae4c26e45 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
dd56e58a76e update fireplace/stove efficiency defaulting
276f9403e86 Latest results.
8601281b4e0 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
39110093225 Latest results.
6d0c3755a0e Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
544a15ad355 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
beefde88b69 update documentation
4948ed5edcd Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
fc1faeb7f0d coarse efficiency defaulting for fireplace/stove Use energyplus.rb for fuel type mapping
48da5c83142 Merge branch 'hvac_dhw_default_efficiencies' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
b9d4fd4e214 code cleanup and add more tests
4ca0de47899 Latest results.
bb4e923461a fix test_furnaces
4e2f3ab4c3b Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
ee5afad48a3 fix base-misc-defaults.xml
631235b169c Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
4bdbd77d33e pick up the rest of the initial comments
2255a1a293c Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
3ad035b7e8a pick up some of the initial comments
21d7ecb8e98 another documentation update
f6c4f7c3dd0 update documentation
f0e0c56b5ed revert assertions for tankless and heatpump water heaters
8a0d1acd330 remove Fixmes
072c0f2ea48 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
5955f3ea884 update hpxml for water heaters and change the assertions for water heater efficiencies
0728f7a1f97 update EPvalidator for water heating systems
861ef8a7b52 Bugfix and update EPvalidator.xml and hpxml.rb
8bf095e758d update test_defaults
2b0fe12a1e0 run tasks.rb
fdc7aadff69 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
6a477f99a83 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
2e50326547a first pass

git-subtree-dir: resources/hpxml-measures
git-subtree-split: cd54d03eff41c456b4c5575164d59e673a4ccec2
aspeake added a commit to NREL/resstock that referenced this pull request Jun 22, 2021
@aspeake
Squashed 'resources/hpxml-measures/' changes from 5184e01c5e..5554ec0524
fc43787 
5554ec0524 didn't save conflict fix
fabacd22e3 Merge remote-tracking branch 'origin/build-res-hpxml-v3' into build-res-hpxml-v3-hes
48a69e938a bugfix for subsurfaces on adiabatic surfaces
d7fa5bd3f5 Remove water heater first hour rating argument.
448937b2e7 add puma argument and pass to xml
68ec5a9755 Remove invalid roof material type choices.
e2cef45d28 Merge branch 'master' into build-res-hpxml-v3
412c1536b8 Improve a few argument descriptions.
8ff9f1b44e Merge pull request #784 from NREL/dhw_usage_bin
26fe68b8cf Latest results.
318431de2d Revise orientation argument description.
2b6749e7f1 Fix sample files.
e4727623fa Small change to docs.
4087b3150b Update changelog.
592e122bc4 First pass.
5569f43051 Latest results.
6ca25b50b0 Merge branch 'master' into build-res-hpxml-v3
ce85f47bb6 Merge pull request #778 from NREL/interior_finish
9dd9d9d992 Merge branch 'interior_finish' of https://github.com/NREL/OpenStudio-HPXML into interior_finish
8a33ac674d Simplify a little.
621e2aeb78 Latest results.
ae48c12615 Bugfix.
fc647c58b9 Merge branch 'interior_finish' of https://github.com/NREL/OpenStudio-HPXML into interior_finish
760a6ef959 Update a couple sample files.
0bdfcdeacd Latest results.
de32dc887e Clean up Material classes and switch to kwargs.
c99acebdf5 Exclude warning.
6101a68a3c Merge branch 'interior_finish' of https://github.com/NREL/OpenStudio-HPXML into interior_finish
2d39a47bb6 Simplify code. Use solar abs and emittance values from ASHRAE 140 for interior finish materials.
464cccfff0 Merge remote-tracking branch 'origin/build-res-hpxml-v3' into build-res-hpxml-v3-hes
ef7e042b8d Latest results.
d58542baa0 Update test values.
768ff3ccc1 Tweak sample files.
5d4e5f7404 First pass.
216e7b13c9 Merge branch 'master' into build-res-hpxml-v3
1522f9e298 Merge pull request #771 from NREL/build-res-hpxml-v3-windows
6d27600714 Merge pull request #770 from NREL/tweak_sample_files
fac5a44fd9 Latest results.
551e336261 Merge branch 'build-res-hpxml-v3' of https://github.com/NREL/OpenStudio-HPXML into build-res-hpxml-v3-windows
32e2c7287f Latest results.
0ed7e855bc Merge branch 'tweak_sample_files' of https://github.com/NREL/OpenStudio-HPXML into build-res-hpxml-v3-windows
70ec879bcf Try to generate measure xml multiple times.
524ca98e6b Fix test.
0b16236638 Merge branch 'tweak_sample_files' of https://github.com/NREL/OpenStudio-HPXML into build-res-hpxml-v3-windows
d65fd6afe3 Ports over the latest window area code from ResStock (including the small bugfix in #597).
c84e98c7c4 Minor tweaks to sample files.
644dd3f041 Latest results.
0636162450 Merge branch 'master' into build-res-hpxml-v3
39eaf1b6d9 Merge pull request #769 from NREL/siding_none
f1b536ccce Latest results.
305ba2b54d Fix sample file and update EPvalidator.xml.
a0b65fd971 First pass.
fa8693e595 Merge pull request #762 from NREL/fan_system_model
ca2e7819e9 Remove FIXMEs
d08b8e6065 Re-enable asserts.
c6bc835744 Merge branch 'fan_system_model' of https://github.com/NREL/OpenStudio-HPXML into fan_system_model
b917947559 Update Changelog.md and add TODOs.
1daf1c7cf7 Latest results.
6eb2a8eaba Latest results.
00801cf912 Ensure we never do integer division.
a71015e6bd Merge branch 'fan_system_model' of https://github.com/NREL/OpenStudio-HPXML into fan_system_model
ff1dfaadda Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into fan_system_model
9924018eaf Fix fan operate for fan coil.
7618bc1f83 Merge pull request #768 from NREL/build-res-hpxml-v3-vacancy-fixes
e6a340834a Merge branch 'build-res-hpxml-v3-vacancy-fixes' of github.com:NREL/OpenStudio-HPXML into build-res-hpxml-v3-vacancy-fixes
d2140b8b81 Improve vacancy testing even further.
34a69cc2b1 Latest results.
32e18bb685 Update tasks and test files.
fad659a939 Update vacancy method for wrap around years.
3591d1c840 Error checking for incomplete vacancy args.
2848e0fca2 Merge branch 'master' into build-res-hpxml-v3
5d318cd6f9 Merge pull request #767 from NREL/reporting_measure_register_values
6781ab87a0 Merge branch 'master' into build-res-hpxml-v3
01d6b1b6cd Need to update outputs section too.
c058375f41 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into reporting_measure_register_values
11e31275ba Fix measures.xmls and add better error checking.
b240cac6eb Update Changelog.md
e9444dbe6f Merge pull request #764 from NREL/allow_ceer
46c758c36c Latest results.
a04aab0bbf address comments
642947059f Update new HVAC test.
0d486dc1cd Clarify docs.
72649984de Fix EMS sensor name.
a41eb40353 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into fan_system_model
642acf1b43 No longer using FanVariableVolume object.
aa622c4474 Handle multi-speed systems.
09e04a3292 Update Changelog.md
aea6428aa4 Register all outputs from the annual CSV with the OS runner (for use in, e.g., PAT).
62ed038f58 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into allow_ceer
a02e9c3a06 Merge branch 'master' into build-res-hpxml-v3
c9e17fa25f Update to most recent create multifamily geometry method.
5e7ab71182 Merge pull request #707 from NREL/gshp-installation-quality
0ba6d727dd Latest results.
5967f50b3b Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into gshp-installation-quality
7023de2595 Removes a few HVAC IQ sample files and renames hvac-install-quality-all-foo.xml files to hvac-install-quality-foo.xml
63ae696601 doc updates and bugfix
40792de798 Simplify logic.
cd54d03eff Adjustments to test osws and mech vent args.
862d056638 Minor docs update.
8601b1021f fix changes caused by merging
de053f828b Cleanup comments
6698525204 Simplified code similarly for other HVAC IQ inputs (blower fan, airflow).
fc8b4d3120 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into gshp-installation-quality
713e829aa1 Removes IsPackagedSystem since split systems can still have pre-charged line sets. We'll just assume that if someone is providing a non-zero value, it makes sense for their system type. Added some documentation to clarify.
3e3ee5719c Merge branch 'master' into build-res-hpxml-v3
fc08a1433f Merge pull request #765 from NREL/default_vent_fan_power
c0b0d06a48 Latest results.
7f04359348 minor change and Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into allow_ceer
8e56249cd3 Allows defaulting of mechanical ventilation fan power (by type).
e6e5c15e28 Merge pull request #674 from NREL/hvac_dhw_default_efficiencies
08db7a78c6 Update Changelog.md
47c8de4a6e Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
7befb82d26 Update projects
3df7ce7b06 Latest results.
c4228096c6 update the default efficiency of the electric type heating systems
a7813c5a9b Latest results.
ef6cdab2f6 allow ceer
18024d07f4 Latest results.
9c280897cf Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into fan_system_model
17f6ebc698 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
8512de8c1c Temporarily disable asserts so all tests run.
1f8403e4fc Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into gshp-installation-quality
f53765eff2 Merge pull request #763 from NREL/mech_vent_precond_energy_only
3ce2810d6a Latest results.
a2c4fb5ddb Code changes from NREL/OpenStudio-HPXML#753, energy impact only.
87c2b51cdc Fix test.
5cac9dbd2a address comments
f315cd2153 Try replacing evap cooler VariableVolume fan too.
aadfde3b04 First pass.
c8872d6cb7 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
95409f512f address comments
4c8870a3ca Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
ce42985088 doc update
824d6959e5 add invalid test
31901ae871 Update Changelog.md
87144acbab Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into gshp-installation-quality
3cdc84532b Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
6e5f10028e fix test_fireplaces
183acefa2d update test_defaults
fe1e69a8b0 Merge branch 'hvac_dhw_default_efficiencies' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
ecae4c26e4 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
dd56e58a76 update fireplace/stove efficiency defaulting
19e7ad5b0c Latest results.
3a69e94324 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into gshp-installation-quality
276f9403e8 Latest results.
8601281b4e Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
3911009322 Latest results.
6d0c3755a0 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
277d71c55c cleanup + fix
7a55ea4b01 Merge branch 'gshp-installation-quality' of https://github.com/NREL/OpenStudio-HPXML into gshp-installation-quality
d50bdd14e1 cleanup
440f6eeccd cleanup for heating hvacsizing method
a274d8ef9b Latest results.
7a20077d2c One more.
5f2a4b8620 Manually fix code that was previously accidentally reverted.
cb9962ec3e Merge branch 'os_v320' of https://github.com/NREL/OpenStudio-HPXML into gshp-installation-quality
7b8bb7ca92 Merge branch 'os_v320' of https://github.com/NREL/OpenStudio-HPXML into gshp-installation-quality
4976c3dcf0 Merge branch 'os_v320' of https://github.com/NREL/OpenStudio-HPXML into gshp-installation-quality
544a15ad35 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
beefde88b6 update documentation
4948ed5edc Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
fc1faeb7f0 coarse efficiency defaulting for fireplace/stove Use energyplus.rb for fuel type mapping
a8f7a9304c revert merging
814183b017 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into gshp-installation-quality
0e94275b49 Add configuration of packaged system with 0 charge defect for schematron test
ca2a92b9d6 Merge branch 'os_v320' of https://github.com/NREL/OpenStudio-HPXML into gshp-installation-quality
f7fb92967c delete repeating rule
6f9f06da1d only gshp to use is_packaged_system
0ab14df133 fix validator.
53b1794cf2 update test file multiple
5cb9bd19e4 Add packaged system element
c3a0676212 Add test for gshp iq
a531df874d Merge branch 'os_v320' of https://github.com/NREL/OpenStudio-HPXML into gshp-installation-quality
370299fbc1 Latest results.
09efbc4f09 Merge branch 'os_v320' of https://github.com/NREL/OpenStudio-HPXML into gshp-installation-quality
05c5934a46 Latest results.
48da5c8314 Merge branch 'hvac_dhw_default_efficiencies' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
b9d4fd4e21 code cleanup and add more tests
4ca0de4789 Latest results.
bb4e923461 fix test_furnaces
4e2f3ab4c3 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
a25e7204cc Merge branch 'os_v320' of https://github.com/NREL/OpenStudio-HPXML into gshp-installation-quality
72ed16096e Added clarification to the docs about packaged vs split GSHPs systems. (Also updated it to remove the "zero only" limitation while I'm in there.)
cdc0bc8028 add charge defect ratio to gshp
ee5afad48a fix base-misc-defaults.xml
631235b169 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
4bdbd77d33 pick up the rest of the initial comments
2255a1a293 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
3ad035b7e8 pick up some of the initial comments
21d7ecb8e9 another documentation update
f6c4f7c3dd update documentation
f0e0c56b5e revert assertions for tankless and heatpump water heaters
8a0d1acd33 remove Fixmes
072c0f2ea4 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
5955f3ea88 update hpxml for water heaters and change the assertions for water heater efficiencies
0728f7a1f9 update EPvalidator for water heating systems
861ef8a7b5 Bugfix and update EPvalidator.xml and hpxml.rb
8bf095e758 update test_defaults
2b0fe12a1e run tasks.rb
fdc7aadff6 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
6a477f99a8 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_dhw_default_efficiencies
2e50326547 first pass

git-subtree-dir: resources/hpxml-measures
git-subtree-split: 5554ec0524f8c64f64bb5dd6e44e220549b33496
@shorowit shorowit mentioned this pull request Nov 15, 2021
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shorowit shorowit Awaiting requested review from shorowit

At least 1 approving review is required to merge this pull request.

Assignees

@yzhou601 yzhou601

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mech vent preconditioning energy use & loads
2 participants
@yzhou601 @shorowit