Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add measure for ShadowCalculation #131

Closed
wants to merge 12 commits into from
Closed

add measure for ShadowCalculation #131

wants to merge 12 commits into from

Conversation

MatthewSteen
Copy link
Member

@MatthewSteen MatthewSteen commented Apr 3, 2023 •
edited
Loading

Adds a measure for the ShadowCalculation class to mainly enable GPU-based shading calcs (Pixel Counting) for Revit work.

@MatthewSteen MatthewSteen marked this pull request as draft April 3, 2023 15:06
@MatthewSteen MatthewSteen marked this pull request as ready for review April 11, 2023 14:51
@MatthewSteen
Copy link
Member Author

MatthewSteen commented Apr 11, 2023 •
edited
Loading

Test fails with a error fatal: detected dubious ownership in repository, which may be related to Docker. For example, see https://github.com/actions/runner-images/issues/6775#issuecomment-1410270956.

@MatthewSteen
Copy link
Member Author

That error was fixed, thanks Tim. However, tests are failing for what looks like unrelated files from this PR.

@MatthewSteen
Copy link
Member Author

MatthewSteen commented May 13, 2023 •
edited
Loading

@tijcolem what's the best fix for these failing tests here and on my other two PRs in this repo or is it a local issue?

Does the fix you committed here need to be included in docker-openstudio?

As far as I can tell, the test_with_openstudio.yml action is the same as our Jenkins CI and could be removed from this repo (it's not present in other measure repos). I can work on those improvements if I'm heading in the correct direction.

DavidGoldwasser
DavidGoldwasser approved these changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@DavidGoldwasser DavidGoldwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to merge into prep-0.8.0 and then that into develop

@MatthewSteen MatthewSteen deleted the add/shadow-calculation branch August 2, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidGoldwasser DavidGoldwasser DavidGoldwasser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MatthewSteen @DavidGoldwasser @tijcolem