Skip to content

Add new dispatch period output for manual dispatch #1298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

brtietz
Copy link
Collaborator

@brtietz brtietz commented Mar 14, 2025

New variable "Battery manual dispatch period in this timestep" should appear for manual dispatch (both front of meter and behind the meter) but not for other dispatch modes.

Chose to do a lifetime variable instead of year 1 since I think we're trying to move in that direction.

Fixes #1230

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13864218817

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 156 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.002%) to 50.427%

Files with Coverage Reduction New Missed Lines %
ssc/shared/lib_battery_dispatch.h 1 70.59%
ssc/shared/lib_battery_dispatch_manual.cpp 8 87.14%
ssc/ssc/cmod_battery.cpp 147 79.48%
Totals Coverage Status
Change from base Build 13861376566: 0.002%
Covered Lines: 65142
Relevant Lines: 129182

💛 - Coveralls

Copy link
Collaborator

@dguittet dguittet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brtietz brtietz merged commit fe39caf into develop Mar 19, 2025
10 checks passed
@brtietz brtietz deleted the ssc_1230_add_dispatch_to_outputs branch April 18, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add battery dispatch periods to outputs
4 participants