-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added passive degrees of freedom #40
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Let's fix/sync the line length for a more consistent style checks and update the pre-commit
config with black-jupyter
, and it should be good to go. Thanks!
def image_digestion(db, uid, image_name): | ||
products = db[uid].table(fill=True) | ||
|
||
for index, entry in products.iterrows(): | ||
image = getattr(entry, f"{image_name}_image") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the images, it's better to use the hdr.data(f"{image_name}_image")
API.
Added passive degrees of freedom
This changes the syntax a little bit. I also refactored a lot of the botorch stuff.