Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated syntax for easier initialization #42

Merged
merged 20 commits into from
Aug 11, 2023
Merged

Conversation

thomaswmorris
Copy link
Collaborator

This is an attempt to make the overhead to construct the agent less verbose. Having the degrees of freedom and tasks as dictionary also gives us more freedom in the backend, e.g. to add/remove degrees of freedom while sequentially optimizing the beamline.

Please give suggestions that would improve the syntax.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I've posted a few suggestions to address the things we discussed.

.github/workflows/testing.yml Outdated Show resolved Hide resolved
bloptools/bayesian/kernels.py Outdated Show resolved Hide resolved
bloptools/devices.py Outdated Show resolved Hide resolved
bloptools/devices.py Outdated Show resolved Hide resolved
bloptools/devices.py Show resolved Hide resolved
bloptools/bayesian/__init__.py Outdated Show resolved Hide resolved
bloptools/bayesian/__init__.py Show resolved Hide resolved
bloptools/bayesian/__init__.py Outdated Show resolved Hide resolved
bloptools/bayesian/__init__.py Outdated Show resolved Hide resolved
bloptools/bayesian/__init__.py Outdated Show resolved Hide resolved
Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work 💯!

@mrakitin mrakitin merged commit 2efadb8 into NSLS-II:main Aug 11, 2023
5 checks passed
@thomaswmorris thomaswmorris deleted the syntax branch September 14, 2023 18:45
thomaswmorris pushed a commit to thomaswmorris/blop that referenced this pull request Jul 15, 2024
Updated syntax for easier initialization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement passive inputs DOC: Update sphinx theme Add more test functions to the notebooks in docs
2 participants