-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated syntax for easier initialization #42
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. I've posted a few suggestions to address the things we discussed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work 💯!
Updated syntax for easier initialization
This is an attempt to make the overhead to construct the agent less verbose. Having the degrees of freedom and tasks as dictionary also gives us more freedom in the backend, e.g. to add/remove degrees of freedom while sequentially optimizing the beamline.
Please give suggestions that would improve the syntax.