Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hypervolume acquisition and constraints #45

Merged
merged 47 commits into from
Sep 28, 2023

Conversation

thomaswmorris
Copy link
Collaborator

Optimization constraints in botorch are weird, so we should just implement our own acquisition functions that we can manually adjust using the output of the classifier.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed through the PR, looks good!
We need to unpin bluesky to be able to deploy on the floor with bluesky v1.10.0.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomaswmorris thomaswmorris merged commit c429cf9 into NSLS-II:main Sep 28, 2023
5 checks passed
@thomaswmorris thomaswmorris deleted the hypervolume branch November 4, 2023 14:32
thomaswmorris added a commit to thomaswmorris/blop that referenced this pull request Jul 15, 2024
Added hypervolume acquisition and constraints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants