Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality for Pareto optimization #65

Merged
merged 5 commits into from
Apr 18, 2024

Conversation

thomaswmorris
Copy link
Collaborator

Pareto optimization is an alternative to scalarization where we explore the Pareto front (https://en.wikipedia.org/wiki/Pareto_efficiency).

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I posted a few comments and suggestions below.

I think what is missing is an example (Jupyter/Sphinx) to demonstrate the Pareto front optimization. Can it be added, please?

src/blop/bayesian/transforms.py Outdated Show resolved Hide resolved
src/blop/tests/test_agent.py Outdated Show resolved Hide resolved
src/blop/utils/functions.py Outdated Show resolved Hide resolved
src/blop/objectives.py Show resolved Hide resolved
src/blop/objectives.py Show resolved Hide resolved
src/blop/agent.py Show resolved Hide resolved
src/blop/agent.py Outdated Show resolved Hide resolved
src/blop/agent.py Outdated Show resolved Hide resolved
DEFAULT_COLORMAP = "magma"
DEFAULT_COLORMAP = "turbo"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's better about this color map?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The values near 1 are hard to see on a white background. Turbo goes from red to blue and isn't white in the middle.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a comment/note about it next to the color map assignment?

src/blop/plotting.py Outdated Show resolved Hide resolved
@mrakitin mrakitin self-requested a review April 18, 2024 00:55
Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need an example. The "approving" review was preliminary.

Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, suggested a couple of minor corrections below, it's good to go after that.

Just to confirm - the learning process will still be the same, i.e. no special input is needed to declare we want to use the Pareto-efficient optimization. The plotting will help to understand the Pareto front and then one can pick some points from the front. Is my understanding correct?

src/blop/plotting.py Show resolved Hide resolved
src/blop/agent.py Outdated Show resolved Hide resolved
@thomaswmorris thomaswmorris merged commit 654410b into NSLS-II:main Apr 18, 2024
5 checks passed
@thomaswmorris
Copy link
Collaborator Author

Looks good, suggested a couple of minor corrections below, it's good to go after that.

Just to confirm - the learning process will still be the same, i.e. no special input is needed to declare we want to use the Pareto-efficient optimization. The plotting will help to understand the Pareto front and then one can pick some points from the front. Is my understanding correct?

Yup, nothing is changed.

thomaswmorris added a commit to thomaswmorris/blop that referenced this pull request Jul 15, 2024
Add functionality for Pareto optimization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants