Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STY: add black formatter for Jupyter notebooks #126

Merged
merged 2 commits into from
Jul 18, 2023
Merged

STY: add black formatter for Jupyter notebooks #126

merged 2 commits into from
Jul 18, 2023

Conversation

mrakitin
Copy link
Member

Format documentation notebooks (.ipynb) with black-jupyter.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@mrakitin mrakitin marked this pull request as ready for review July 16, 2023 17:40
jklynch
jklynch reviewed Jul 17, 2023
View reviewed changes
Copy link
Contributor

@jklynch jklynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to choose --line-length=78? It seems short.

@mrakitin
Copy link
Member Author

Yes, it's for the code to fit the relatively narrow fields in Jupyter notebooks used in the docs (with 2 sidebars).

image

Let me try to increase it a bit so that this code block looks nicer.

jklynch
jklynch approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@jklynch jklynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the explanation!

@mrakitin
Copy link
Member Author

This looks slightly better / less lines:

image

Thanks for your review, @jklynch.

@mrakitin mrakitin merged commit 76d11b9 into NSLS-II:main Jul 18, 2023
8 checks passed
@mrakitin mrakitin deleted the sty-black-jupyter branch July 18, 2023 16:26
@mrakitin mrakitin mentioned this pull request Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklynch jklynch jklynch approved these changes

@AbbyGi AbbyGi Awaiting requested review from AbbyGi AbbyGi is a code owner

@thomaswmorris thomaswmorris Awaiting requested review from thomaswmorris thomaswmorris is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrakitin @jklynch