Propagation parameters #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlb131
requested review from
AbbyGi,
jklynch,
mrakitin and
thomaswmorris
as code owners
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
rlb131
force-pushed
the
propagation-parameters
branch
from
01cb528
to
7ad0b07
Compare
mrakitin
reviewed
Jul 20, 2023
sirepo_bluesky/sirepo_ophyd.py
Outdated
| if sim_type == "srw": | ||
| post_prop_params = connection.data["models"]["postPropagation"] | ||
| sirepo_propagation = [] | ||
| object_name = "postPropagation" |
There was a problem hiding this comment.
Please see how we did name normalization for the objects (snake_case) vs. classes (CamelCase).
| if sim_type == "srw" and model_field == "beamline": | ||
| prop_params = connection.data["models"]["propagation"][str(el["id"])][0] | ||
| sirepo_propagation = [] | ||
| object_name += "_propagation" |
There was a problem hiding this comment.
Maybe we also need to apply inflection here.
| globals().update(**objects) | ||
|
|
||
| assert not srw_empty_simulation.data["models"]["beamline"] | ||
| objects.pop("postPropagation") |
There was a problem hiding this comment.
This will chance once the name is "snake_cased".
Comment on lines
264
to
266
| postPropagation.hrange_mod.kind = "hinted" # noqa F821 | ||
|
|
||
| (uid,) = RE(bp.scan([sample], postPropagation.hrange_mod, 0.1, 0.3, num_steps)) # noqa F821 |
There was a problem hiding this comment.
postPropagation -> post_propagation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sirepo_dataparameter from thecreate_classesfunction as it was redundant.