Skip to content

Decompile dWmConnect_c - #137

Closed
alvaroms97 wants to merge 1 commit into
NSMBW-Community:masterfrom
alvaroms97:decomp/wm-connect-c
Closed

alvaroms97 wants to merge 1 commit into
NSMBW-Community:masterfrom
alvaroms97:decomp/wm-connect-c

Conversation

@alvaroms97

Copy link
Copy Markdown
Contributor

Decompiles dWmConnect_c and its nested dPnt_c point struct — the world map point-connection graph builder. It reads CSV-defined world map points and links them into a directed 6-way (up/down/front/back/left/right) graph, consumed by the world map enemy pathing code.

Verified with progress.py --verify-bin (all 5 binaries byte-identical to the original).

Adds the world map point-connection graph builder: `dWmConnect_c` and
its nested `dPnt_c` point struct, used to link CSV-defined world map
points into a directed 6-way (up/down/front/back/left/right) graph
consumed by the world map enemy pathing code.
@decomp-dev

decomp-dev Bot commented Sep 13, 2026

Copy link
Copy Markdown

Report for SMNP01 (aef4d15 - 6382ad9)

📈 Matched code: 8.92% (+0.04%, +2332 bytes)
📈 Linked code: 8.93% (+0.04%, +2332 bytes)
📈 Matched data: 2.25% (+0.00%, +4 bytes)
📈 Linked data: 3.99% (+0.00%, +108 bytes)

✅ 23 new matches
Unit Item Bytes Before After
dol/bases/d_wm_connect.cpp dWmConnect_c::__connect(int, int) +408 0.00% 100.00%
dol/bases/d_wm_connect.cpp dWmConnect_c::SetInfo(dCsvData_c&, const m3d::mdl_c&) +376 0.00% 100.00%
dol/bases/d_wm_connect.cpp dWmConnect_c::initAnimation(dCsvData_c&) +200 0.00% 100.00%
dol/bases/d_wm_connect.cpp dWmConnect_c::calcConnect(dCsvData_c&) +188 0.00% 100.00%
dol/bases/d_wm_connect.cpp dWmConnect_c::initialize(dCsvData_c&, const m3d::mdl_c&) +164 0.00% 100.00%
dol/bases/d_wm_connect.cpp dWmConnect_c::GetDir(int, int) +140 0.00% 100.00%
dol/bases/d_wm_connect.cpp dWmConnect_c::GetCourseNoFromName(const char*) +132 0.00% 100.00%
dol/bases/d_wm_connect.cpp dWmConnect_c::GetConnect(const char*, int) +128 0.00% 100.00%
dol/bases/d_wm_connect.cpp dWmConnect_c::GetPointNo(const char*) +112 0.00% 100.00%
dol/bases/d_wm_connect.cpp __sinit_\d_wm_connect_cpp +112 0.00% 100.00%
dol/bases/d_wm_connect.cpp dWmConnect_c::dPnt_c::SetInfo(const char*, nw4r::math::VEC3&, int) +104 0.00% 100.00%
dol/bases/d_wm_connect.cpp dWmConnect_c::dPnt_c::init() +88 0.00% 100.00%
dol/bases/d_wm_connect.cpp dWmConnect_c::SetCourseNo(int) +72 0.00% 100.00%
dol/bases/d_wm_connect.cpp dWmConnect_c::GetPointFromIndex(int) +64 0.00% 100.00%
dol/bases/d_wm_connect.cpp __arraydtor$11774 +28 0.00% 100.00%
dol/bases/d_wm_connect.cpp dWmConnect_c::dPnt_c::GetLink(int) +16 0.00% 100.00%
dol/bases/d_wm_connect.cpp .ctors +4 0.00% 100.00%
runtime/global_destructor_chain.c __register_global_object -4 100.00% 100.00%
runtime/global_destructor_chain.c __register_global_object -4 100.00% 100.00%
runtime/global_destructor_chain.c __register_global_object -4 100.00% 100.00%
runtime/global_destructor_chain.c __destroy_global_chain -12 100.00% 100.00%
runtime/global_destructor_chain.c __destroy_global_chain -12 100.00% 100.00%
runtime/global_destructor_chain.c __destroy_global_chain -12 100.00% 100.00%
🥀 3 broken matches
Unit Item Bytes Before After
runtime/global_destructor_chain.c .dtors -8 100.00% 0.00%
runtime/global_destructor_chain.c .dtors -4 100.00% 0.00%
runtime/global_destructor_chain.c .dtors -4 100.00% 0.00%
📈 8 improvements in unmatched items
Unit Item Bytes Before After
dol/bases/d_wm_connect.cpp .data +37 0.00% 94.74%
dol/bases/d_wm_connect.cpp .sdata2 +21 0.00% 90.91%
dol/bases/d_wm_connect.cpp .sdata +14 0.00% 89.66%
dol/bases/d_wm_connect.cpp .bss +12 0.00% 75.00%
runtime/global_destructor_chain.c .sbss +5 0.00% 66.67%
runtime/global_destructor_chain.c .sbss +5 0.00% 66.67%
runtime/global_destructor_chain.c .sbss +5 0.00% 66.67%
dol/bases/d_wm_connect.cpp .sbss +5 0.00% 66.67%
📉 3 regressions in unmatched items
Unit Item Bytes Before After
runtime/global_destructor_chain.c .bss -5 66.67% 0.00%
runtime/global_destructor_chain.c .bss -5 66.67% 0.00%
runtime/global_destructor_chain.c .bss -5 66.67% 0.00%

@CLF78

CLF78 commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

The NSMBW Decomp maintainers have set up rules regarding the use of AI in decompilation work for this project - please see https://github.com/NSMBW-Community/NSMBW-Decomp/blob/master/README.md. As a result, this pull request will be closed without merging and we ask you to refrain from submitting any further such PRs.

@CLF78 CLF78 closed this Sep 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants