Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tmpdir for Categorify out_path in test_tf4rec #1832

Merged
merged 2 commits into from
Jun 5, 2023

Conversation

oliverholworthy
Copy link
Member

Use tmpdir for Categorify out_path in test_tf4rec. This avoids conficts when re-running the test in the same environment.

@oliverholworthy oliverholworthy added this to the Merlin 23.06 milestone Jun 5, 2023
@oliverholworthy oliverholworthy self-assigned this Jun 5, 2023
@github-actions
Copy link

github-actions bot commented Jun 5, 2023

Documentation preview

https://nvidia-merlin.github.io/NVTabular/review/pr-1832

@nv-alaiacano
Copy link
Contributor

The test_tf4rec.py test is passing, so I'm going to force this PR through.

@nv-alaiacano nv-alaiacano merged commit 69fbd57 into main Jun 5, 2023
5 of 6 checks passed
@nv-alaiacano nv-alaiacano deleted the test-tf4rec-categorify-tmpdir branch June 5, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants