Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nulls in categorify encode to array instead of index value #1836

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

oliverholworthy
Copy link
Member

@oliverholworthy oliverholworthy commented Jun 7, 2023

Follow-up to #1692

Update nulls in categorify _encode function to array instead of index type.

This fixes an error we're seeing in our container builds with newer versions of cupy.

import cupy
import cudf

labels = cupy.array([3, 3, 3, 3, 3, 2, 2, 2, 2, 2, 5, 5, 4, 4, 4])
nulls = cudf.Index([5, 6, 7, 8, 9], dtype='int64')
labels[nulls] = 1
# =>
# TypeError: no implementation found for 'numpy.min_scalar_type' on types that implement __array_function__: [<class 'cudf.core.index.Int64Index'>]

@oliverholworthy oliverholworthy added this to the Merlin 23.06 milestone Jun 7, 2023
@oliverholworthy oliverholworthy self-assigned this Jun 7, 2023
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Documentation preview

https://nvidia-merlin.github.io/NVTabular/review/pr-1836

@oliverholworthy oliverholworthy merged commit f1165d8 into main Jun 7, 2023
8 checks passed
@oliverholworthy oliverholworthy added the skip-changelog Exclude from change log label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci skip-changelog Exclude from change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants