Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle copying of partitioned stat files when saving workflow #1838

Merged
merged 3 commits into from
Jun 7, 2023

Conversation

nv-alaiacano
Copy link
Contributor

Addresses #1837

For operators that produce a directory of partitioned files rather than a single parquet file, we will copy the partitions to the expected target path when saving the Workflow.

There's also a small tweak to the save/load paths to make it easier to use other path-like types (eg tmpdir)

@nv-alaiacano nv-alaiacano added this to the Merlin 23.06 milestone Jun 7, 2023
@nv-alaiacano nv-alaiacano self-assigned this Jun 7, 2023
@nv-alaiacano nv-alaiacano added the bug Something isn't working label Jun 7, 2023
@nv-alaiacano nv-alaiacano added the skip-changelog Exclude from change log label Jun 7, 2023
tox.ini Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Documentation preview

https://nvidia-merlin.github.io/NVTabular/review/pr-1838

@rnyak rnyak requested a review from rjzamora June 7, 2023 16:28
@nv-alaiacano nv-alaiacano merged commit 4b7957a into main Jun 7, 2023
6 checks passed
@nv-alaiacano nv-alaiacano deleted the laiacano/categorify-part-files branch June 7, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore skip-changelog Exclude from change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants