Call .stop() on dataloader in test_dataloader_schema
#1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview |
This was referenced Jun 28, 2023
karlhigley
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call
.stop()on dataloader intest_dataloader_schemaThis fixes an issue with long-running tests in NVTabular in docker environments.
Without this call to stop. The dataloader background thread is still running, because not all the batches have been iterated through.
This causes problems when combined with the pytest coverage extension
pytest-covwhich seems to cause this thread to not be cleaned up automatically and later tests become very slow due to some resouce contention.This came up in #1829 which runs the tests on GPU in a different GitHub Actions Runner.