Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of deprecated np.bool and np.long #1851

Merged
merged 4 commits into from
Jul 4, 2023

Conversation

oliverholworthy
Copy link
Member

Replace deprecated np.bool with bool in FillMisisng operator

Fixes the following error that shows up in test_fill.py with newer numpy versions

E           AttributeError: module 'numpy' has no attribute 'bool'.
E           `np.bool` was a deprecated alias for the builtin `bool`. To avoid this error in existing code, use `bool` by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use `np.bool_` here.
E           The aliases was originally deprecated in NumPy 1.20; for more details and guidance see the original release note at:
E               https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations. Did you mean: 'bool_'?

@oliverholworthy oliverholworthy added this to the Merlin 23.07 milestone Jun 23, 2023
@oliverholworthy oliverholworthy self-assigned this Jun 23, 2023
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/NVTabular/review/pr-1851

@oliverholworthy oliverholworthy changed the title Replace deprecated np.bool with bool in FillMisisng operator Remove usage of deprecated np.bool and np.long Jun 23, 2023
@oliverholworthy oliverholworthy merged commit 24136ef into main Jul 4, 2023
6 checks passed
@oliverholworthy oliverholworthy deleted the ops-fill-numpy-bool branch July 4, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants