Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of DataFrame merge from test_embedding_cat_export_import #1853

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

oliverholworthy
Copy link
Member

@oliverholworthy oliverholworthy commented Jun 29, 2023

Remove use of DataFrame merge from test_embedding_cat_export_import

DataFrames merges in cuDF result in non-deterministic row ordering which was causing problems with this test running on certain devices (e.g. P100 GPUs).

@oliverholworthy oliverholworthy added this to the Merlin 23.07 milestone Jun 29, 2023
@oliverholworthy oliverholworthy self-assigned this Jun 29, 2023
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/NVTabular/review/pr-1853

@oliverholworthy oliverholworthy merged commit aad1112 into main Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants