Remove use of DataFrame merge from test_embedding_cat_export_import
#1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DataFrames merges in cuDF result in non-deterministic row ordering https://docs.rapids.ai/api/cudf/stable/api_docs/api/cudf.dataframe.merge/
oliverholworthy
force-pushed
the
test-workflow-remove-merge
branch
from
df16e23
to
6615d34
Compare
Documentation preview |
karlhigley
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove use of DataFrame merge from
test_embedding_cat_export_importDataFrames merges in cuDF result in non-deterministic row ordering which was causing problems with this test running on certain devices (e.g. P100 GPUs).