Skip to content

Conversation

suiyoubi
Copy link
Contributor

@suiyoubi suiyoubi commented Sep 9, 2025

Description

Usage

# Add snippet demonstrating usage

Checklist

  • I am familiar with the Contributing Guide.
  • New or Existing tests cover these changes.
  • The documentation is up to date with these changes.

Copy link

copy-pr-bot bot commented Sep 9, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@suiyoubi suiyoubi requested a review from abhinavg4 September 9, 2025 02:07
Signed-off-by: Ao Tang <[email protected]>
Copy link
Contributor

@abhinavg4 abhinavg4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left a few comments but overall I think this tutorial looks a bit verbose. Is it possible for you to check it once to ensure that contents are correct. Eg:- I saw "libx264 (CPU, highest quality)" Is this true?

"cell_type": "markdown",
"metadata": {},
"source": [
"## Installation and Setup\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They need to run these steps before running this notebook right? Can we add installation (Should be done before starting the notebook) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly not sure what is the best way here. I think we should just link a docker container once we have it so that the user don't need to install any deps (doing deps installation in juypter notebook especially with some cuda related dep can be problematic from my eperience with NeMo)

Signed-off-by: Ao Tang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants