-
Notifications
You must be signed in to change notification settings - Fork 184
Add video pipeline tutorial #1052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Ao Tang <[email protected]>
Signed-off-by: Ao Tang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left a few comments but overall I think this tutorial looks a bit verbose. Is it possible for you to check it once to ensure that contents are correct. Eg:- I saw "libx264 (CPU, highest quality)" Is this true?
"cell_type": "markdown", | ||
"metadata": {}, | ||
"source": [ | ||
"## Installation and Setup\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They need to run these steps before running this notebook right? Can we add installation (Should be done before starting the notebook) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly not sure what is the best way here. I think we should just link a docker container once we have it so that the user don't need to install any deps (doing deps installation in juypter notebook especially with some cuda related dep can be problematic from my eperience with NeMo)
Signed-off-by: Ao Tang <[email protected]>
Description
Usage
# Add snippet demonstrating usage
Checklist