feat(logging): improve event logging and add bot thinking display #1434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This was referenced Oct 2, 2025
tgasser-nv
approved these changes
Oct 3, 2025
| bot_thinking_logs = [ | ||
| record | ||
| for record in caplog.records | ||
| if "Event :: BotThinking" in record.message |
There was a problem hiding this comment.
nit: Should we define an enum with these strings if there are a static set of events? It would be more robust to typos
| for event in next_events: | ||
| if event["type"] != "EventHistoryUpdate": | ||
| event_type = event["type"] | ||
| log.info( |
There was a problem hiding this comment.
nit: Should this be a log.debug() rather than log.info()? How much noise would this make in logs?
| if event_name == "BotThinking": | ||
| title = f"[blue]{title}[/] [yellow bold]{event_name}[/]" | ||
| elif event_name.startswith("Start") and event_name.endswith("Action"): | ||
| title = f"[magenta][bold]Start[/]{event_name[5:]}[/]" |
There was a problem hiding this comment.
Where does the magic number 5 come from here?
| elif event_name.startswith("Start") and event_name.endswith("Action"): | ||
| title = f"[magenta][bold]Start[/]{event_name[5:]}[/]" | ||
| elif event_name.endswith("ActionFinished"): | ||
| title = f"[magenta]{event_name[:-8]}[bold]Finished[/][/]" |
There was a problem hiding this comment.
Another magic number here, is there a danger we add longer-named events and this breaks?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack Info
This PR is part of a stack:
#1427 → #1431 → #1432
Description
Enhanced event logging in the runtime and callbacks to better display bot thinking events with reasoning traces. Moved event logging to occur after event generation for proper ordering, added reasoning content extraction from LLM completions, and improved console output formatting for different event types.
Changes