fix(nemotron_3.5_super): repin vllm-router to the current head of #238 - #3107
Merged
Conversation
The pin added in #3080 pointed at a commit that also carried per-role balance threshold flags (--prefill-balance-abs-threshold and friends). Those were an escape hatch we never needed: they default to the existing global values, so they are inert unless passed, and nothing here passes them. They have been dropped from vllm-project/router#238 to keep the PR to the bug fix, so this moves the pin to the new head. No behaviour change. The remaining commits are unchanged: #216 (health checker no longer resets in-flight worker load) plus the fix for the prefill-side regression #216 exposes, where cache_aware decided prefix affinity from the fleet-wide load spread instead of per request. Repinning also removes an incidental dependency: the previously pinned commit is only reachable through a contributor branch, whereas the new one is the current PR head. Signed-off-by: Sugam Devare <sdevare@nvidia.com>
bxyu-nvidia
approved these changes
Sep 4, 2026
jkyi-nvidia
pushed a commit
that referenced
this pull request
Sep 11, 2026
#3107) The pin added in #3080 pointed at a commit that also carried per-role balance threshold flags (--prefill-balance-abs-threshold and friends). They have been dropped from vllm-project/router#238 to keep the PR to the bug fix, so this moves the pin to the new head. No behaviour change. The remaining commits are unchanged: #216 (health checker no longer resets in-flight worker load) plus the fix for the prefill-side regression #216 exposes, where cache_aware decided prefix affinity from the fleet-wide load spread instead of per request. Signed-off-by: Sugam Devare <sdevare@nvidia.com> Signed-off-by: Junkeun Yi <jkyi@nvidia.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pin added in #3080 pointed at a commit that also carried per-role balance threshold flags (--prefill-balance-abs-threshold and friends). They have been dropped from vllm-project/router#238 to keep the PR to the bug fix, so this moves the pin to the new head.
No behaviour change. The remaining commits are unchanged: #216 (health checker no longer resets in-flight worker load) plus the fix for the prefill-side regression #216 exposes, where cache_aware decided prefix affinity from the fleet-wide load spread instead of per request.