Conversation
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expected
When a tokenless rollout declares
terminal_response_id, capture reconstruction should mask the sample if that ID cannot be confirmed, even when the captured calls form one clean chain. Masked capture evidence should remain available.Actual
Terminal attribution rejects an unknown declared ID, but the consumer then applies its ordinary single-chain fallback. It returns
mask_sample=False, allowing the captured chain to be used with the rollout reward and making its evidence eligible for retirement.Fix
Mask unconfirmed declarations at the shared consumer boundary. Extend the existing file-store finalization regression to cover a single chain as well as auxiliary roots, and check retirement eligibility and unchanged reward. Valid declarations and the existing fallback without a declaration keep their behavior.
This enforces the declaration contract introduced in #2872; no separate issue is needed.
Validation: 246 focused capture tests, core and sandbox suites, the coverage gate, and all-file pre-commit passed. Model rollouts are N/A for this shared finalization-only change.