ns tools stability #658
Merged
ns tools stability #658
+115
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add disable_session_restore flag (enabled by default in config) to skip session history replay after sandbox worker restarts, avoiding O(n) replay overhead that caused 76% of >31s tool call wall time - Add verbose_tool_logging flag (disabled by default) for per-call and per-session timing metrics - Decrease code execution timeout from 30s to 10s for faster failure - Track tool execution timing per session and report metrics in verify response (total time, avg time, timeout counts) - Detect both internal sandbox timeouts and HTTP/request-level timeouts - Update nemo-skills requirement to georgea/super-rl-02062026 Signed-off-by: George Armstrong <georgea@nvidia.com>
Only track per-session timing data and aggregate metrics when verbose_tool_logging is enabled. Avoids unnecessary dict accumulation and perf_counter overhead when timing is not needed. Signed-off-by: George Armstrong <georgea@nvidia.com>
bxyu-nvidia
approved these changes
Feb 6, 2026
bxyu-nvidia
previously approved these changes
Feb 6, 2026
verify() now takes a request param for session-based timing. Pass None in tests since verbose_tool_logging defaults to false. Signed-off-by: George Armstrong <georgea@nvidia.com>
bxyu-nvidia
approved these changes
Feb 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary