Add SLURM-aware exp manager run timer - #16214
Open
pzelasko wants to merge 1 commit into
Open
Conversation
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
Collaborator
Author
|
/ok to test 860b0f7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Allow
exp_manager.max_time_per_runto optionally count from the start of the current SLURM allocation so preprocessing and setup time cannot consume the checkpoint safety margin unnoticed.Collection: Core / experiment manager
Changelog
max_time_per_run_from_slurmconfiguration field.SLURM_JOB_START_TIMEUNIX timestamp.Usage
GitHub Actions CI
The changed core files and documentation should select the relevant GitHub Actions checks.
Before your PR is "Ready for review"
Pre checks:
PR Type:
Validation
pre-commit runpre-commit run --from-ref origin/main --to-ref HEADpytest -q --cpu -m unit tests/core_ptl/test_ptl_stateless_timer.py— 13 passed, 1 GPU-only test skippeduv sync --locked --group docsuv run make -C docs html— succeeded; 190 pre-existing optional-import and duplicate-toctree warningsgit diff --check origin/main...HEADNot run: the full repository and GPU test suites, because the change is isolated to timer bookkeeping and is covered by focused CPU unit tests.
Additional Information
No linked issue.