fix(escalation): require fresh consistent failure evidence - #632
Closed
pst2154 wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Alex Steiner <asteiner@nvidia.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Agent harnesses can represent one command both as assistant JSON/text and as a structured tool call. The trajectory judge could count those same-turn representations as repeated failed attempts. More generally, boolean-only confirmations could combine stale evidence or unrelated failure modes into a false escalation.
The new confirmation rule keeps the existing one-way latch while requiring a coherent multi-turn failure pattern. This is a focused correctness improvement related to the signal-composition direction discussed in #601.
Live SWE-Atlas diagnostics with GLM 5.2 as the efficient tier and Opus 4.8 as the capable tier:
task-697e7458be1623d850a88838: two consecutive freshrepetitionverdicts caused exactly one GLM-to-Opus transition; the run used 28 GLM and 36 Opus worker calls and received verifier reward 1.repetitionvotes separated by a decline did not latch; the GLM-only run received verifier reward 1.task-69391d8d1ce51c407be1e531, RFtask-694b4b99829f00e24fd11889, and TWtask-6902ef3ab97fe23e2ad271f3all remained GLM-only under the new rule. In the first case, positive votes changed fromrepetitiontofalse_progress, so they did not combine into a latch.These are routing diagnostics, not an aggregate accuracy claim: the positive-path task also passed in a separate direct-GLM rollout, and the false-positive controls still received reward 0. The evidence shows correct confirmation/latch behavior and avoided strong-tier calls on previously wasteful trajectories.
Notes for reviewers
Start with
crates/libsy/src/algorithms/escalation.rsfor the confirmation state machine andcrates/libsy/src/algorithms/util/escalation.rsfor judge transcript normalization and typed verdicts.Validation on Rust 1.96.1:
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-features -- -D warningscargo test --workspace --all-featuresuv run ruff check .uv run mypy switchyarduv run pytest tests/ -v(117 passed,2 subtests passed)