fix(arc_agi_3): exit non-zero when the harness produces no result.json - #180
Merged
esarafian merged 2 commits intoSep 10, 2026
Merged
Conversation
run_solver.main() prints an error when the harness exits without writing result.json, but then falls through to 'return 0'. Any wrapper or CI job reading the exit code sees success for a run that produced nothing. Return 1 on that path so the printed failure and the exit status agree. The success path is unchanged, so the e2e test's returncode assertion still holds. Signed-off-by: Shicheng Rao <122049441+ShichengRao@users.noreply.github.com>
Signed-off-by: Elad Sarafian <esarafian@nvidia.com>
esarafian
approved these changes
Sep 10, 2026
esarafian
left a comment
Collaborator
There was a problem hiding this comment.
The production fix remains a single return 1 after the existing cleanup and durable-result check. Added a credential-free, normally collected regression covering missing/valid result.json with harness exit 0/1: all four cases pass; the original source fails both missing-result cases. Valid-result behavior, artifact copy-back, and cleanup are preserved. Ruff lint and format checks pass. Fork CI is approved and running; merge will wait for successful checks. 🤖🤖🤖
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
run_solver.main()prints an error when the harness exits without writingresult.json— and then falls through toreturn 0. Any wrapper or CI job reading the exit code sees success for a run that produced nothing. (We hit this integratingrun_solverinto an offline evaluation rig: a fully failed run looked successful to our automation until we checked artifacts.)This returns 1 on that path so the printed failure and the exit status agree. The success path is unchanged, so
test_offline_e2e'sreturncode == 0assertion still holds — and now actually discriminates.Related issues
None filed; happy to open one if you prefer tracking it that way.
Checklist
python -m astparses the file (ruff/pytest not run locally — no formatting-sensitive lines touched)