docs(cli): name the core package nooa, not nemo-oo-agents 🤖🤖🤖 - #287
Open
sushant-mishra-dtu wants to merge 1 commit into
Open
sushant-mishra-dtu wants to merge 1 commit into
sushant-mishra-dtu wants to merge 1 commit into
Conversation
nooa-cli's PyPI strapline and README told users it was the CLI for a package called nemo-oo-agents. Its declared dependency is nooa, and nemo-oo-agents is not a distribution this project publishes. The description field is what shows on the PyPI project page, so this is the package's front door. The three lines are leftovers from 68ebfca ("rename: distribution names nemo-labs-oo-agents-* -> nooa-*"), whose stated goal was to make the pip distribution names match the Python modules. That commit edited both of these files, including this very README sentence: -`nemo-labs-oo-agents-cli` automatically pulls in matching `nemo-oo-agents` +`nooa-cli` automatically pulls in matching `nemo-oo-agents` The sweep matched nemo-labs-oo-agents, so the first name on the line was renamed and the second -- spelled nemo-oo-agents, without labs -- was not. The same commit changed "nemo-labs-oo-agents>=0.2.0" to "nooa>=0.2.0" while leaving the description line directly above it untouched. Every other nemo-oo-agents occurrence is a genuinely different package or a non-package reference and is left alone: mcp/oauth.py:747 (the MCP wire clientInfo, which is protocol-visible), THIRD_PARTY_NOTICES.md (nemo-oo-agents-benchmarks), tests/test_mcp/__init__.py (mcp-nemo-oo-agents), tests/tracing/__init__.py (openinference-instrumentation-nemo-oo-agents), pyproject.toml:31, and nooa_cli/commands/eval.py:59 (the monorepo, not a pip name). nemo-oo-agents-nvidia, a separate NVIDIA package, is not in this diff. Signed-off-by: sushant-mishra-dtu <sushant.arh@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughUpdated Changesnooa naming updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This updates CLI documentation and package metadata to consistently identify the core package as nooa. No current merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
nooa-clitells users, in its PyPI strapline and its README, that it is the CLI for apackage called
nemo-oo-agents. Its actual dependency isnooa, andnemo-oo-agentsisnot a distribution this project publishes.
Three lines:
packages/nooa-cli/pyproject.toml:5description = "CLI for nemo-oo-agents (…)"nooapackages/nooa-cli/README.md:3CLI for [nemo-oo-agents](…)nooapackages/nooa-cli/README.md:14automatically pulls in matching `nemo-oo-agents`nooaThe
descriptionfield is the strapline shown on the PyPI project page, so this isuser-facing on the package's front door.
Why these three were missed
They are leftovers from the distribution rename in
68ebfca("rename: distribution names nemo-labs-oo-agents-* -> nooa-*"), whose stated goal was
to "make the pip distribution names match the Python modules". That commit edited both
of these files — and edited the README sentence in question:
The sweep matched
nemo-labs-oo-agents, so the first name on that line was renamed andthe second — spelled
nemo-oo-agents, withoutlabs— was not. The same commit changedthe dependency itself (
"nemo-labs-oo-agents>=0.2.0"→"nooa>=0.2.0") while leavingthe
descriptiondirectly above it untouched.That commit was also explicit about what it left deliberately ("Left as-is: the
'NeMo Labs' branding badge in README (org branding, not a package name)"), which is the
distinction applied below.
What this deliberately does NOT touch
Every other
nemo-oo-agentsoccurrence in the tree is either a genuinely differentpackage or a non-package reference, and is left alone:
src/nooa/mcp/oauth.py:747—"clientInfo": {"name": "nemo-oo-agents"}. This is theidentity sent to MCP servers on the wire; changing it would be a protocol-visible
behaviour change, not a docs fix.
THIRD_PARTY_NOTICES.md—nemo-oo-agents-benchmarks, a separate distribution.tests/test_mcp/__init__.py,tests/tracing/__init__.py—mcp-nemo-oo-agentsandopeninference-instrumentation-nemo-oo-agents, both separate packages.pyproject.toml:31— a comment aboutmcp-nemo-oo-agents(now internal).packages/nooa-cli/src/nooa_cli/commands/eval.py:59— "ships with the nemo-oo-agentsmonorepo workspace", a reference to the repo, not to a pip name.
nemo-oo-agents-nvidia, which is a real and unrelated NVIDIA package, does not appear inthis diff.
Scope
Docs and packaging metadata only — three lines, no code, no test changes.
ruff check .and
ruff format --check .are clean and the suite is unchanged.