fix: restore valid CODEOWNERS teams - #2344
Conversation
Signed-off-by: Swarom Muley <smuley@nvidia.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: NVIDIA-NeMo/nemo-helix/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe CODEOWNERS rules now assign NMP teams. The rename tool skips ChangesCODEOWNERS preservation
Suggested reviewers: Priority: ⬇️ Low Change: Bug fix Merge Risk: ⚪ Minimal · up to The PR restores valid team ownership while preserving those assignments during renaming, with no merge-blocking issue identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
|
Summary
GitHub reports every
nhx_*team in.github/CODEOWNERSas an unknown owner, so CODEOWNERS review routing is ineffective. Restore the existingnmp_*teams, which have access to this repository, without changing the path rules.Changes
nmp_teamandnmp_maintainersfor the default rule.nmp_devopsfor.github/andrelease/.Type of Change
Quality Gates
Verification
Signed-off-by:traileruv run pre-commit run -apasses, or any blocked checks are identified belowTargeted validation:
gh api repos/NVIDIA-NeMo/nemo-helix/codeowners/errors: reports four unknown owner references for the currentnhx_*teams onmain.gh api repos/NVIDIA-NeMo/nemo-helix/teams --paginate: confirmsnmp_team(push),nmp_maintainers(maintain), andnmp_devops(admin) are repository teams.git diff --check: passed.f20bd5aa9).UV_CACHE_DIR=/private/tmp/nemo-helix-uv-cache uv run --frozen pytest tests/tools/rename/test_rename_tools.py::test_codeowners_team_slugs_are_preserved -v: passed (1 test).tools/rename/verify-nemo-helix-rename.sh --include-glob .github/CODEOWNERS: passed.UV_CACHE_DIR=/private/tmp/nemo-helix-uv-cache uv run pre-commit run -a: the rename, Ruff, ty, lock-drift, copyright, merge-conflict, and Flox-lock checks passed. The full run failed on local environment prerequisites:uv0.11.26 instead of pinned 0.10.10, toolchain version checks, Helm docs, and missinglint-stagedunder the host Node version. A pinned Flox retry was interrupted before completion. The full gate remains unverified.Summary by CodeRabbit
.github/CODEOWNERSare now preserved during automated repository renaming, keeping approval routing intact.