Skip to content

fix: restore valid CODEOWNERS teams - #2344

Merged
svvarom merged 2 commits into
mainfrom
fix-codeowners-teams/svvarom
Sep 24, 2026
Merged

svvarom merged 2 commits into
mainfrom
fix-codeowners-teams/svvarom

Conversation

@svvarom

@svvarom svvarom commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary

GitHub reports every nhx_* team in .github/CODEOWNERS as an unknown owner, so CODEOWNERS review routing is ineffective. Restore the existing nmp_* teams, which have access to this repository, without changing the path rules.

Changes

  • Use nmp_team and nmp_maintainers for the default rule.
  • Use nmp_devops for .github/ and release/.
  • Preserve these external GitHub team slugs in the rename-consistency tooling, with a focused regression test.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with documentation updates
  • Documentation only
  • Contributor tooling or automation
  • CI, build, or test infrastructure

Quality Gates

  • Tests added or updated for changed behavior
  • Existing tests cover changed behavior — justification:
  • Tests not applicable — justification:
  • Documentation updated for user-visible behavior
  • Documentation not applicable — justification: Review ownership changes only; no user-facing behavior or documentation changes.

Verification

  • Pull request title follows the repository's Conventional Commit format
  • Every commit includes an appropriate Signed-off-by: trailer
  • uv run pre-commit run -a passes, or any blocked checks are identified below
  • Targeted tests pass, or tests are marked not applicable above
  • No secrets, API keys, or credentials are included

Targeted validation:

  • gh api repos/NVIDIA-NeMo/nemo-helix/codeowners/errors: reports four unknown owner references for the current nhx_* teams on main.
  • gh api repos/NVIDIA-NeMo/nemo-helix/teams --paginate: confirms nmp_team (push), nmp_maintainers (maintain), and nmp_devops (admin) are repository teams.
  • git diff --check: passed.
  • The updated file matches the CODEOWNERS file before the repository rename (f20bd5aa9).
  • UV_CACHE_DIR=/private/tmp/nemo-helix-uv-cache uv run --frozen pytest tests/tools/rename/test_rename_tools.py::test_codeowners_team_slugs_are_preserved -v: passed (1 test).
  • tools/rename/verify-nemo-helix-rename.sh --include-glob .github/CODEOWNERS: passed.
  • UV_CACHE_DIR=/private/tmp/nemo-helix-uv-cache uv run pre-commit run -a: the rename, Ruff, ty, lock-drift, copyright, merge-conflict, and Flox-lock checks passed. The full run failed on local environment prerequisites: uv 0.11.26 instead of pinned 0.10.10, toolchain version checks, Helm docs, and missing lint-staged under the host Node version. A pinned Flox retry was interrupted before completion. The full gate remains unverified.

Summary by CodeRabbit

  • Updates
    • Updated repository review ownership so default approvals are routed to the NMP team and maintainers, with GitHub and release approvals routed to NMP DevOps.
    • Ownership rules in .github/CODEOWNERS are now preserved during automated repository renaming, keeping approval routing intact.

Signed-off-by: Swarom Muley <smuley@nvidia.com>
@github-actions github-actions Bot added the fix label Sep 23, 2026
@svvarom
svvarom marked this pull request as ready for review September 23, 2026 23:04
@svvarom svvarom self-assigned this Sep 23, 2026
@svvarom
svvarom requested a review from mquong-ca September 23, 2026 23:06
@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: NVIDIA-NeMo/nemo-helix/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: eb454886-3ca4-4fba-8468-6ab5ccb093cd

📥 Commits

Reviewing files that changed from the base of the PR and between 8ce606f and 580398e.

📒 Files selected for processing (3)
  • .github/CODEOWNERS
  • tests/tools/rename/test_rename_tools.py
  • tools/rename/rename_common.py

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The CODEOWNERS rules now assign NMP teams. The rename tool skips .github/CODEOWNERS, and a test checks that the file remains unchanged after the tool runs.

Changes

CODEOWNERS preservation

Layer / File(s) Summary
Update and preserve CODEOWNERS
tools/rename/rename_common.py, .github/CODEOWNERS, tests/tools/rename/test_rename_tools.py
The CODEOWNERS rules now use NMP teams. The rename tool excludes the file, and a test verifies that it remains unchanged and the verifier reports no legacy product.

Suggested reviewers: mckornfield

Priority: ⬇️ Low

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 64189

The PR restores valid team ownership while preserving those assignments during renaming, with no merge-blocking issue identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: restoring valid teams in .github/CODEOWNERS.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@crookedstorm crookedstorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@svvarom
svvarom enabled auto-merge September 23, 2026 23:11
@svvarom
svvarom added this pull request to the merge queue Sep 23, 2026
@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 48858/60799 80.4% 64.7%
Integration Tests 31468/57771 54.5% 26.1%

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 23, 2026
@svvarom
svvarom added this pull request to the merge queue Sep 24, 2026
@svvarom
svvarom removed this pull request from the merge queue due to a manual request Sep 24, 2026
@svvarom
svvarom enabled auto-merge September 24, 2026 00:06
@svvarom
svvarom added this pull request to the merge queue Sep 24, 2026
Merged via the queue into main with commit 56703e0 Sep 24, 2026
68 of 69 checks passed
@svvarom
svvarom deleted the fix-codeowners-teams/svvarom branch September 24, 2026 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants