fix: address critical and high CVE findings - #1103
Conversation
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (9)
🚧 Files skipped from review as they are similar to previous changes (9)
📝 WalkthroughWalkthroughThe changes raise dependency minimums and update Docker image remediation. Runtime builds now install the CVE cleanup script, pin Pillow, and remove stale Pillow files. ChangesDependency and image remediation
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (1)
CVE_SUMMARY.md (1)
1-5: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd the required documentation structure.
This page records facts and verification evidence, so classify it as REFERENCE. Put a short status summary and a
## Prerequisitessection before## Artifacts Reviewed. Add a## Next Stepssection after## Verificationfor the required image rescan and Studio tests.As per coding guidelines, Markdown pages must fit one Diataxis quadrant, list prerequisites at the top, and include a
Next Stepssection at the end.Also applies to: 96-97
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@CVE_SUMMARY.md` around lines 1 - 5, Add the required REFERENCE-page structure in CVE_SUMMARY.md: place a concise status summary and a ## Prerequisites section before ## Artifacts Reviewed, and add ## Next Steps after ## Verification describing the required image rescan and Studio tests. Keep the page focused on factual evidence and verification.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CVE_SUMMARY.md`:
- Around line 77-78: Update the verification command in CVE_SUMMARY.md to invoke
summarize_findings.py through a repository-relative path or another portable
tool location, removing the host-specific /home/mkornfield/home/skills prefix.
Verify the documented command works from a fresh checkout before retaining it.
- Around line 49-51: Update the `nmp-cpu-tasks`, `nmp-automodel-training`, and
`nmp-unsloth-training` entries in `CVE_SUMMARY.md` to describe their
remediations as expected or pending rather than confirmed. Reserve definitive
“addressed” wording until rebuilt images receive a fresh Pulse scan confirming
the package fixes and stale-file removal.
In `@docker/scripts/cve-cleanup.sh`:
- Around line 90-92: Update the Pillow cleanup command in the CVE cleanup script
to remove the packages from the active /app/.venv Python 3.13 environment
instead of the Python 3.12 system paths, covering the Pillow package, native
libraries, and dist-info metadata; then verify the rebuilt CPU image no longer
contains the vulnerable installation.
In `@pyproject.toml`:
- Line 269: Update the Automodel image dependency constraints in its Dockerfile
to require GitPython>=3.1.57,<4 and pyasn1>=0.6.4,<1, matching the project
dependency floors. Rebuild the image and run the image security scan to verify
the updated constraints.
---
Nitpick comments:
In `@CVE_SUMMARY.md`:
- Around line 1-5: Add the required REFERENCE-page structure in CVE_SUMMARY.md:
place a concise status summary and a ## Prerequisites section before ##
Artifacts Reviewed, and add ## Next Steps after ## Verification describing the
required image rescan and Studio tests. Keep the page focused on factual
evidence and verification.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: ed093274-8705-4a3c-b777-6cc53d020f37
⛔ Files ignored due to path filters (3)
services/guardrails/callouts/go.sumis excluded by!**/*.sumuv.lockis excluded by!**/*.lockweb/pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (10)
CVE_SUMMARY.mddocker/Dockerfile.auditor-tasksdocker/Dockerfile.nmp-cpu-tasksdocker/Dockerfile.nmp-unsloth-trainingdocker/automodel/Dockerfile.nmp-automodel-basedocker/scripts/cve-cleanup.shpyproject.tomlservices/core/models/pyproject.tomlservices/guardrails/callouts/go.modweb/pnpm-workspace.yaml
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
fd6f6df to
79d43ac
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Summary
security.ymlrun 31002650434CVE Notes
langchain-community<0.4is currently capped forragas 0.4.3compatibility, and the Pulse OSS report givesragasunknown upgrade guidance.Verification
uv lock --checkcd services/core/jobs/jobs-launcher && go test ./...cd services/guardrails/callouts && go test ./...cd web && pnpm install --lockfile-onlyrg -n "vitest@4\\.1\\.9|@vitest/(coverage-v8|ui)@4\\.1\\.9|vitest: \\^4\\.1\\.9|version: 4\\.1\\.9" web/pnpm-workspace.yaml web/pnpm-lock.yamlgit diff --check origin/main...HEADbash -n docker/scripts/cve-cleanup.shdocker buildx bake --print nmp-cpu-tasks-dockerCaveats
v22.18.0, below the repo requirement>=22.23.2 <23.web/node_moduleswas not cleaned or refreshed; only the lockfile was updated.Summary by CodeRabbit
Bug Fixes
Maintenance