-
Notifications
You must be signed in to change notification settings - Fork 22
docs: align current-release Install and Upgrade with Setup #1851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
glody
wants to merge
1
commit into
release/0.5
Choose a base branch
from
docs-nvbug-6734000/glody
base: release/0.5
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: NVIDIA-NeMo/nemo-platform
Length of output: 2157
🌐 Web query:
official Flox documentation flox activate -c command mode child shell💡 Result:
The flox activate command in Flox is used to activate a project environment. It supports several execution modes, including a command mode that allows you to run specific commands within an activated environment without launching an interactive shell [1]. The two primary ways to run commands in an activated environment are: 1. Shell Command Mode (-c): You can use the -c flag to execute a specific shell command string within a subshell started in the activated environment [1]. Example: flox activate -c "npm run build" The shell used to execute this command is determined by the $FLOX_SHELL environment variable, or it falls back to$SHELL [1]. Because this mode runs within a shell, it supports standard shell features like command chaining (e.g., &&) [1]. 2. Exec Command Mode (--): You can use the -- separator to run a specific command or script directly within the activated environment [1]. Example: flox activate -- cargo run This approach is particularly useful for running scripts or binaries contained within the profile [1]. In both cases, Flox launches a subshell to execute the command, ensuring that the environment variables and dependencies configured for that project are active for the duration of that command [1][2][3]. This is distinct from "in-place" activation, which is typically used to modify the current shell's state (often via eval "$ (flox activate)") [1][4].
Citations:
🤖 get_repo_knowledge executed:
get_repo_knowledge NVIDIA-NeMo/nemo-platform /tmp/coderabbit-repo-knowledge/nvidia-nemo-nemo-platform-f69ed47d/learnings /tmp/coderabbit-repo-knowledge/nvidia-nemo-nemo-platform-f69ed47d/conventionsLength of output: 47744
🌐 Web query:
site:flox.dev/docs/man/flox-activate "flox activate" subshell script no command💡 Result:
When you run
flox activatewithout providing a specific command (via the-cflag or the--separator), it enters interactive mode [1]. In this mode,flox activatelaunches an interactive subshell configured with the environment's variables and packages [1]. The specific shell executable used for this subshell is determined by theFLOX_SHELLenvironment variable, or if that is not set, it defaults to theSHELLenvironment variable [1]. If you wish to behave differently, such as modifying the current shell in-place rather than spawning a new subshell, you can use the in-place mode by evaluating the output of the command in your current shell: eval "$(flox activate)" This method emits shell commands that configure your existing session instead of launching a new, nested shell process [1].Citations:
Run
nemo setupinside the Flox environment.flox -q activatestarts a separate shell. The separatenemo setupcommand is not guaranteed to use that environment. Use Flox command mode:Proposed fix
Apply this change to both the install and upgrade source-checkout flows.
📝 Committable suggestion
🤖 Prompt for AI Agents
Source: MCP tools