Skip to content

chore: make helm app and chart versions clearer placeholders - #1866

Open
mckornfield wants to merge 1 commit into
mainfrom
move-helm-semver-placeholder/mck
Open

chore: make helm app and chart versions clearer placeholders#1866
mckornfield wants to merge 1 commit into
mainfrom
move-helm-semver-placeholder/mck

Conversation

@mckornfield

@mckornfield mckornfield commented Sep 8, 2026

Copy link
Copy Markdown
Contributor
  • Use 0.0.0 as the placeholder, so it's clearer when using source installations

Summary by CodeRabbit

  • Chores
    • Updated Helm chart and application version metadata to 0.0.0.
    • Aligned the Authentik deployment chart’s platform dependency version with 0.0.0.
    • Updated validation expectations to reflect the revised chart dependency version.
    • Added release metadata references to the chart information.

@mckornfield
mckornfield requested review from a team as code owners September 8, 2026 16:40
@github-actions github-actions Bot added the chore label Sep 8, 2026
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0fdd8d82-b71e-4167-ab48-b21b6440721e

📥 Commits

Reviewing files that changed from the base of the PR and between 11accf6 and a8c3967.

📒 Files selected for processing (3)
  • contrib/auth/authentik/helm/Chart.yaml
  • k8s/helm/Chart.yaml
  • tests/auth_idp/static/test_authentik_kubernetes_demo.py

Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The Helm chart and application versions change to 0.0.0. The Authentik dependency and its test expectation change to the same version. Release overwrite and catalog comments are added.

Changes

Helm versioning

Layer / File(s) Summary
Update Helm version metadata
k8s/helm/Chart.yaml
The chart and application versions change to 0.0.0. Release overwrite and catalog comments are added.
Align dependency metadata and test expectation
contrib/auth/authentik/helm/Chart.yaml, tests/auth_idp/static/test_authentik_kubernetes_demo.py
The nemo-platform dependency version and the corresponding test expectation change to 0.0.0.

Suggested reviewers: ironcommit

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to a8c39

This change makes source Helm installations use clear 0.0.0 placeholders while keeping the dependent Authentik chart metadata and test expectation aligned. No concrete current-head merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (2 skipped: 2 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: updating Helm application and chart versions to clearer placeholder values.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (2 skipped: 2 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch move-helm-semver-placeholder/mck

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 39102/50069 78.1% 62.2%
Integration Tests 23780/47297 50.3% 23.0%

Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
@mckornfield
mckornfield force-pushed the move-helm-semver-placeholder/mck branch from 11accf6 to a8c3967 Compare September 8, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant