refactor(cli): rewrite workspaces, projects and iam on typed clients - #1999
Draft
maxdubrinsky wants to merge 15 commits into
Draft
refactor(cli): rewrite workspaces, projects and iam on typed clients#1999maxdubrinsky wants to merge 15 commits into
maxdubrinsky wants to merge 15 commits into
Conversation
Adds what hand-written CLI commands need from nemo_platform_plugin: - InferenceGatewayClient (provider/model/openai proxy routes, provider_ready, raw SSE streams, OpenAI model listing) with endpoint and wire tests. - client_from_platform accepts a NemoClient or AsyncNemoClient and derives the typed client with from_client, so callers no longer need to know which platform handle they hold; PlatformClient is the runtime-checkable structural type for that parameter and platform_default_headers reads identity headers off either shape. - models.refs holds the pure model-reference helpers; packages/models re-exports them so the CLI does not import the Stainless-bound package. - filesets.transfer holds SDK-free upload/download/list/delete; FilesResource delegates to it and filesets no longer imports .resources eagerly. - Bearer tokens are resolved on every HTTP attempt rather than baked into the PreparedRequest, so retries and later pages never replay a stale token. - A 409 on a create sent with exist_ok is no longer retried before send() resolves it by fetching the existing entity. - Query-param TypedDicts and request models for files, iam, virtual models and workspaces gain the fields the CLI exposes; GuardrailConfig.data is optional to match the server entity. Signed-off-by: Max Dubrinsky <mdubrinsky@nvidia.com>
…ands Additive plumbing so command groups can be rewritten on the typed clients one PR at a time while the generated commands keep working: - client/bootstrap.py resolves config, OIDC discovery and token providers without the generated SDK and builds NemoClient/AsyncNemoClient with the same retry policy, TLS verification and 5 s connect cap the SDK used; factory.py layers the NeMoPlatform constructors on top of it. - CLIContext.typed_client(XClient) / async_typed_client derive a service client that shares the platform client's transport and auth; get_workspace exposes the configured default. - pagination gains collect_offset_pages / collect_cursor_pages for typed paginated responses, carrying the server's envelope fields (sort, filter, grouped_by) into JSON output; fetch_all_pages stays for generated commands. - errors maps typed-client and pydantic errors alongside the SDK ones (validation and unknown --input-data keys exit 2), and recognises every unresolved-workspace message. - stdin_utils.build_request_body validates --input-data into a request model and rejects unknown keys instead of dropping them. - code_generator renders typed-client snippets (request models as constructor calls, SecretStr masked, RootModel positional); generated commands are routed to legacy_code_generator until they are replaced. - waiters accept either platform handle, poll with a monotonic clock and normalise str-enum statuses; formatters unwrap NemoResponse; the version flag reads distribution metadata; command groups no longer advertise shell completion (the root app owns it). Signed-off-by: Max Dubrinsky <mdubrinsky@nvidia.com>
…p calls it The new test endpoint stubs raise NotImplementedError like their siblings instead of an ellipsis body, which ty rejects as an implicit None return. The auth-idp CLI refresh contract test patches discover_nmp_config on client.bootstrap, where the CLI now resolves OIDC settings. Signed-off-by: Max Dubrinsky <mdubrinsky@nvidia.com>
AllPagesResponse and OffsetPageResponse emit the server envelope fields, but callers that build them without an envelope (fetch_all_pages behind the generated list commands, and nemo jobs list --all-pages) lost the sort key that list output has always carried. sort is now always present, null when the server did not echo one, and a real envelope keeps its own field order. Signed-off-by: Max Dubrinsky <mdubrinsky@nvidia.com>
- Narrow the platform handle from object to PlatformClient in client_from_platform and platform_default_headers (adapter.py) and the nemo.sdk resource-factory owner in NemoPluginSDKResources (sdk.py), so the typed-client boundary stops erasing the type where plugins are built. - build_request_body reports each field's accepted input alias in the unknown-input hint (schema, not the internal schema_) so the advertised key is one pydantic actually accepts. - with_options now clears a clone's cached nemo.sdk plugin resources, which were built against the original client's transport, so typed clients accessed on the clone bind to its headers/retry/timeout. - Drop the always-false _PLATFORM_JOB_LIFECYCLE watch exclusions from the legacy code generator's lifecycle helpers. Signed-off-by: Max Dubrinsky <mdubrinsky@nvidia.com>
Brings in the auth-off-Stainless SDK removal, customization typed-client migration, and sandbox forward merges. Resolves conflicts in adapter.py and client.py by combining both sides: keep main's _owns_http lifecycle (owns_http_client=False) and _platform_default_headers header resolution, and keep the PlatformClient narrowing plus the with_options cached-resource clearing added for review. Signed-off-by: Max Dubrinsky <mdubrinsky@nvidia.com>
This was referenced Sep 11, 2026
The main merge kept the typed resource factories on PlatformClient but took main's __all__ which no longer re-exports NeMoPlatform/AsyncNeMoPlatform, so the import became dead and tripped the ruff pre-commit hook (lint-python-style). Signed-off-by: Max Dubrinsky <mdubrinsky@nvidia.com>
Plugins (nemo-evaluator among others) import the generated NeMoPlatform / AsyncNeMoPlatform classes from nemo_platform_plugin.sdk. My earlier drop of that import broke them with an ImportError. Re-export lazily through a module __getattr__ so plugin discovery still imports this module without requiring the generated SDK at load time. Signed-off-by: Max Dubrinsky <mdubrinsky@nvidia.com>
Brings in guardrails typed-client (#1966) and other main changes. Resolved guardrail/types.py to main's landed GuardrailConfig.data shape (RailsConfig, typed) per the layered-merge rule, and took main's add/add tests/guardrail/test_endpoints.py. Also fixes the sdk.py re-export regression in the same push. Signed-off-by: Max Dubrinsky <mdubrinsky@nvidia.com>
maxdubrinsky
force-pushed
the
cli-core-groups-1/mdubrinsky
branch
from
September 11, 2026 18:36
3f012f3 to
cf4563c
Compare
maxdubrinsky
changed the base branch from
cli-typed-client-plumbing/mdubrinsky
to
main
September 11, 2026 18:50
Contributor
|
maxdubrinsky
force-pushed
the
cli-core-groups-1/mdubrinsky
branch
from
September 11, 2026 19:45
cf4563c to
37ad7aa
Compare
maxdubrinsky
changed the title
…bing-merge Signed-off-by: Max Dubrinsky <mdubrinsky@nvidia.com> # Conflicts: # packages/nemo_platform_ext/src/nemo_platform_ext/cli/core/errors.py
maxdubrinsky
force-pushed
the
cli-core-groups-1/mdubrinsky
branch
from
September 11, 2026 20:09
37ad7aa to
8d63423
Compare
…bing-merge Signed-off-by: Max Dubrinsky <mdubrinsky@nvidia.com>
maxdubrinsky
force-pushed
the
cli-core-groups-1/mdubrinsky
branch
from
September 11, 2026 20:44
8d63423 to
0398178
Compare
…bing-merge Signed-off-by: Max Dubrinsky <mdubrinsky@nvidia.com>
…bing-merge Signed-off-by: Max Dubrinsky <mdubrinsky@nvidia.com> # Conflicts: # packages/nemo_platform_plugin/tests/client/test_adapter.py
maxdubrinsky
force-pushed
the
cli-core-groups-1/mdubrinsky
branch
from
September 11, 2026 21:04
0398178 to
219ef33
Compare
…bing-merge Signed-off-by: Max Dubrinsky <mdubrinsky@nvidia.com>
Hand-written Typer groups for workspaces (with members), projects and iam
on the typed clients from the plumbing PR, replacing their generated
Stainless commands. The CLI surface, output shapes and exit codes are
unchanged: list commands go through collect_offset_pages so --all-pages and
the {data, sort, pagination} envelope match the generated output, and
--input-data bodies go through build_request_body, which rejects unknown
fields with exit code 2 and the accepted field list.
The generated workspaces and projects modules are removed and the generator
config marks them skip: true so make generate-cli-commands cannot bring them
back. The generated iam group was already removed by the core auth port
(#1968); this adds the hand-written hidden group back on IAMClient.
Secrets is not part of this PR: #1971 landed its own port of that group.
Signed-off-by: Max Dubrinsky <mdubrinsky@nvidia.com>
maxdubrinsky
force-pushed
the
cli-core-groups-1/mdubrinsky
branch
from
September 11, 2026 21:49
219ef33 to
e144a7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rewrites the
workspaces,projectsandiamcommand groups by hand on the typed clients from #1986, replacing their generated Stainless commands. CLI surface, output shapes and exit codes are unchanged; the generated workspaces/projects modules are removed and the generator is told to skip them somake generate-cli-commandscannot resurrect them. The generatediamgroup was already removed by #1968; this adds the hand-written hidden group back onIAMClient.secretswas dropped from this PR after #1971 landed its own port of that group. A small follow-up will move that port onto the shared helpers (collect_offset_pages,build_request_body) so unknown---input-data-key rejection applies there too; it is not a blocker for the flip, since #1971'sclient_from_platform(state.get_client(), SecretsClient)keeps working onceget_client()returns aNemoClient.Changes
cli/commands/{workspaces,projects,iam}.py: hand-written Typer groups onCLIContext.typed_client(...); list commands usecollect_offset_pagesso--all-pagesand the{data, sort, pagination}envelope match the generated output byte for byte;--input-databodies go throughbuild_request_body, which rejects unknown fields with exit code 2 and the accepted field list.iam revokesendswait_role_propagationonly when the user passes it (the server default isTrue, same as before).manifest_registry.pyregisters the three groups as top-level entries;cli_config.yamlmarks workspaces/projectsskip: true;cli/commands/api/{workspaces,projects}deleted.httpx.MockTransport(tests/cli/commands/test_{workspaces,projects,iam}.py) asserting method, path, query, body and rendered output, plus the--helpsnapshot tests.Stack
Part of the AIRCORE-893 series that moves the
nemoCLI off the generated Stainless SDK onto the typed clients innemo_platform_plugin(blocking AIRCORE-827). Stacked on #1986 (plumbing) but targeted atmainso CI runs (theCIworkflow only triggers for PRs againstmain/release/*). Until #1986 merges, the diff includes its commits; this PR's own change isrefactor(cli): rewrite secrets, workspaces, projects and iam on typed clients. Review that commit, or compare againstcli-typed-client-plumbing/mdubrinsky.get_client()'s Stainless path, deletecli/commands/api/*and the CLI generatorStatus: draft. Being maintained by an agent on behalf of @mdubrinsky; it re-bases on #1986 as that moves and on @ironcommit's landing plugin migrations (#1971, #1973), and picks up CI and review feedback. It will be re-cut where those PRs overlap (noted per PR below).
Type of Change
Quality Gates
--helpoutput anddocs/cli/reference.mdxare unchanged.Verification
Signed-off-by:traileruv run pre-commit run -apasses, or any blocked checks are identified belowTargeted validation (on the current head, based on #1986 at
377fb4d0a):uv run --frozen pytest packages/nemo_platform_ext/tests packages/nemo_platform_plugin/tests -q --deselect packages/nemo_platform_ext/tests/cli/commands/test_services.py --deselect packages/nemo_platform_ext/tests/local/test_services.py(the two deselected files bind ports 8080/9000, which are occupied on the host): 3761 passed (packages/nemo_platform_ext/tests).uv run ruff checkanduv run ruff format --check: clean.uv run pre-commit run -a: all hooks pass exceptuv-lock(host uv 0.9.30 vs pinned 0.9.14);uvx --from uv==0.9.14 uv lock --checkpasses.helm-docsandyqare not installed on the host; both hooks are CI-covered.NMP_CONFIG_FILE=/tmp/nope.yaml uv run _nemo <group> --helpdiffed againstmainfor every rewritten group: identical, except a trailing period on group help lines.