ci: cache the embed model for the k8s smoke tests - #384
Conversation
Signed-off-by: Brooke Storm <brookes@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughReplaces HF_TOKEN secret injection in the CPU smoke Docker build with a GitHub Actions-managed FastEmbed model cache. The cache is restored before the build, populated on miss via ChangesFastEmbed Cache Integration
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yaml:
- Around line 251-260: The cache save condition in the "Save fastembed model
cache" step is too restrictive by excluding pull_request events, which prevents
cache persistence on PRs and causes repeated re-downloads. Update the event_name
check in the if condition to also include pull_request events alongside push and
workflow_dispatch events, allowing the cache to be saved during PR runs when
there is a cache miss. Additionally, ensure you have Write permissions before
editing files in folders starting with a dot like .github/workflows/.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 2c92544a-ee0b-475c-bb73-ac42fc29589a
📒 Files selected for processing (3)
.github/workflows/ci.yamldocker-bake.hcldocker/Dockerfile.nmp-api
Signed-off-by: Brooke Storm <brookes@nvidia.com>
|
Signed-off-by: Brooke Storm <brookes@nvidia.com>
Down loading the qdrant/all-MiniLM model for every PR is causing 429s. Using the cache makes sense for this, and it likely needs exactly one cache, period, not something that is keyed to a particular PR or commit.
Summary by CodeRabbit