Skip to content

ci: remove stale docker-build PR status workflows - #425

Merged
svvarom merged 1 commit into
mainfrom
remove-docker-build-status/smuley
Jun 23, 2026
Merged

ci: remove stale docker-build PR status workflows#425
svvarom merged 1 commit into
mainfrom
remove-docker-build-status/smuley

Conversation

@svvarom

@svvarom svvarom commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

What changed

This removes the old docker-build PR status path:

  • the small PR trigger workflow
  • the workflow that posted the commit status and handed the work off outside this repo
  • the liveness workflow that marked stuck statuses as failed

Why

That status used to stand in for Docker build coverage that was not directly visible in this repo. That is no longer the right tradeoff.

The missing container build coverage now runs in this repo's own CI after #423, and the old commit status was hard to act on when it failed or timed out. Contributors could see that docker-build failed, but the status did not give them a useful repo-local job to inspect or rerun.

This keeps the PR check surface simpler: Docker build signal comes from visible CI jobs, not a separate commit status with poor diagnostics.

Validation

  • actionlint .github/workflows/*.yaml .github/workflows/*.yml
  • git diff --check HEAD~1..HEAD
  • rg -n "docker-build|DOCKER_BUILD_TIMEOUT_MIN|Commit statuses" .github docs release scripts tests packages services pyproject.toml README.md

Signed-off-by: Swarom Muley <smuley@nvidia.com>
@svvarom
svvarom requested a review from a team as a code owner June 23, 2026 21:48
@github-actions github-actions Bot added the ci label Jun 23, 2026
@svvarom svvarom self-assigned this Jun 23, 2026
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 07a5c417-8634-4688-97ab-fa2c0129a5f1

📥 Commits

Reviewing files that changed from the base of the PR and between 89214a3 and fa30b70.

📒 Files selected for processing (3)
  • .github/workflows/docker-build-dispatch.yml
  • .github/workflows/docker-build-liveness.yml
  • .github/workflows/docker-build-trigger.yml
💤 Files with no reviewable changes (3)
  • .github/workflows/docker-build-trigger.yml
  • .github/workflows/docker-build-dispatch.yml
  • .github/workflows/docker-build-liveness.yml

📝 Walkthrough

Walkthrough

Removes three GitHub Actions workflows: docker-build-trigger (fired on PR events), docker-build-dispatch (posted docker-build pending status and triggered downstream docker-pr-build dispatch), and docker-build-liveness (cron job that failed stale pending statuses after a timeout).

Changes

Docker Build Workflow Removal

Layer / File(s) Summary
Remove Docker build trigger, dispatch, and liveness workflows
.github/workflows/docker-build-trigger.yml, .github/workflows/docker-build-dispatch.yml, .github/workflows/docker-build-liveness.yml
Deletes all three workflows that handled PR-triggered Docker build status signaling, downstream repo dispatch, and pending-status timeout enforcement.

Possibly related PRs

Suggested labels

ci

Suggested reviewers

  • mquong-ca
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'ci: remove docker-build status workflows' directly describes the main change—deletion of three Docker build-related workflow files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-docker-build-status/smuley

Comment @coderabbitai help to get the list of available commands.

@svvarom svvarom changed the title ci: remove docker-build status workflows ci: remove stale docker-build PR status workflows Jun 23, 2026
@svvarom
svvarom requested a review from crookedstorm June 23, 2026 21:52
@github-actions

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 20908/27474 76.1% 61.2%
Integration Tests 12109/26243 46.1% 19.5%

@crookedstorm crookedstorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svvarom
svvarom added this pull request to the merge queue Jun 23, 2026
Merged via the queue into main with commit afb3001 Jun 23, 2026
55 checks passed
@svvarom
svvarom deleted the remove-docker-build-status/smuley branch June 23, 2026 22:18
crookedstorm pushed a commit that referenced this pull request Jun 24, 2026
Signed-off-by: Swarom Muley <smuley@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants