Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WiP] Provide a dev container for DALI #5017

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Aug 24, 2023

Category:

Description:

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@JanuszL JanuszL marked this pull request as draft August 24, 2023 11:25
@JanuszL JanuszL mentioned this pull request Aug 24, 2023
18 tasks
@@ -0,0 +1,94 @@
ARG DEPS_IMAGE_NAME
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should consider skipping this container, unless we want to have an option to tinker with different targets in dev container.
Still, this is mostly an artifact of how we use it in CI, and most of those options can be controlled directly with CMake invocation inside the dev container.

The next step would be a layer that adds the tools for testing/debugging instead of this one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, I would leave it as it is and use it to create test env. When it is done, we can merge it with Dockerfile.deps.ubuntu (unless there is a part that needs to have cuda installed already).

@JanuszL JanuszL force-pushed the dev_container branch 11 times, most recently from b051115 to 8769089 Compare August 31, 2023 13:43

# to be adjusted later, first it to run from the build dir, the second is for nose test
# so the user can `python3 -m nose_wrapper --verbose`
ENV PYTHONPATH=/opt/dali/test_comp/dali/python/:/opt/dali/qa
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank to that you can just

cd dali/test/python/
python3 -m nose2 --verbose -s operator_1 test_constant

or

cd dali/test/python/
python3 -m nose_wrapper --verbose

Any suggestion how to improve that?

Signed-off-by: Janusz Lisiecki <[email protected]>
@JanuszL JanuszL changed the title Provide a dev container for DALI [WiP] Provide a dev container for DALI Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants