Fix access to unitialized memory in RNG ops #5394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Operator used vector of reintereted bytes with assignment of std::distribution object carrying some state. Switch to a vector so the copy and move are not UB. Signed-off-by: Krzysztof Lecki <[email protected]>
|
CI MESSAGE: [13784528]: BUILD STARTED |
|
CI MESSAGE: [13784528]: BUILD FAILED |
JanuszL
reviewed
Mar 26, 2024
JanuszL
approved these changes
Mar 26, 2024
stiepan
approved these changes
Mar 26, 2024
mzient
reviewed
Mar 26, 2024
| dists_cpu.resize(sizeof(Dist) * nsamples); // memory was already reserved in the constructor | ||
| Dist* dists = reinterpret_cast<Dist*>(dists_cpu.data()); | ||
| bool use_default_dist = !This().template SetupDists<T>(dists, ws, nsamples); | ||
| std::vector<Dist> dists(nsamples); |
There was a problem hiding this comment.
This is captured by value in task lambdas (see line 162 and 180).
mzient
requested changes
Mar 26, 2024
|
Same fix with less allocations reimplemented in #5395 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category: Bug fix
Description:
Random operators used vector of reinterpreted bytes as a target of assignment when creating distribution objects.
The random choice uses non-trivial
std::discrete_distributioncarrying some state. Assigning to that memory caused a leak.Switch to a proper
vector<distribution>, so the copy/move assignments are not UB as the location that we assign to is nowproperly constructed ahead of time.
Additional information:
Affected modules and functionalities:
RNG operators
Key points relevant for the review:
Tests:
The relevant fn.random.choice tests no longer report leak under ASAN.
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A