Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin librosa as it currently causes an issue about: cannot allocate memory in static TLS block #5510

Closed
wants to merge 5 commits into from

Conversation

jantonguirao
Copy link
Contributor

@jantonguirao jantonguirao commented Jun 7, 2024

Category:

Other

Description:

Unpins librosa version from tests
Adjusts usage of librosa trim function to match new semantics (see librosa/librosa#1445)

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

…memory in static TLS block

Signed-off-by: Joaquin Anton <[email protected]>
@JanuszL
Copy link
Contributor

JanuszL commented Jun 7, 2024

I'm afraid it will break our tests. See librosa/librosa#1445.

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15648147]: BUILD STARTED

@mzient mzient self-assigned this Jun 7, 2024
@JanuszL JanuszL self-assigned this Jun 7, 2024
@JanuszL JanuszL changed the title Unpin librosa as it currently causes an issue about: cannot allocate … Unpin librosa as it currently causes an issue about: cannot allocate memory in static TLS block Jun 7, 2024
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15648654]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15648671]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15651562]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15651562]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15669752]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15669752]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15676949]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15677024]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15677024]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15678255]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15678255]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15735146]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15736057]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15736057]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15738171]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15742104]: BUILD STARTED

Signed-off-by: Joaquin Anton <[email protected]>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15743383]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15738171]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15743383]: BUILD FAILED

@jantonguirao jantonguirao marked this pull request as draft June 12, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants