Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failure tests for stealing subgraphs. Minor fix in pipeline. #5518

Merged

Conversation

mzient
Copy link
Contributor

@mzient mzient commented Jun 11, 2024

Follow-up on #5506

Category:

Bug fix (non-breaking change which fixes an issue)
Other (e.g. Documentation, Tests, Configuration)

Description:

This change adds failure tests to the pipeline, detecting:

  • uncheckpointable pipeline (with foreign subgraph)
  • invalid pipeline (with duplicate node names)

Minor fix:

  • error out in Python (instead of C++) when adding a node with a duplicate name

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Comment on lines +725 to +727
ops = ops_by_name.get(op.name, None)
if ops is None:
ops = ops_by_name[op.name] = []
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This made the test always pass (the dictionary was empty). There was another check in C++, so it's not critical.

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15740515]: BUILD STARTED

@NVIDIA NVIDIA deleted a comment from dali-automaton Jun 11, 2024
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15740515]: BUILD PASSED

@mzient mzient merged commit 398e27d into NVIDIA:main Jun 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants