ExternalSource refactoring and fixing #5690
Conversation
mzient
force-pushed
the
external_source_refactoring_and_fixes
branch
from
0a7d371
to
2d912c3
Compare
|
CI MESSAGE: [19728778]: BUILD STARTED |
|
CI MESSAGE: [19728778]: BUILD FAILED |
mzient
force-pushed
the
external_source_refactoring_and_fixes
branch
from
fcbed73
to
717a164
Compare
|
CI MESSAGE: [19730281]: BUILD STARTED |
|
CI MESSAGE: [19730281]: BUILD FAILED |
|
CI MESSAGE: [19730281]: BUILD PASSED |
| int device_id = order.is_device() ? order.device_id() : tl_elm->data.device_id(); | ||
| cudaEvent_t event = tl_elm->GetCompletionEvent(order.device_id()); | ||
|
|
||
| if (order.device_id() != device_id_ && |
There was a problem hiding this comment.
This condition is unreadable, can you make it a function with readable name? Like is is_ambiguous_order in access_order.cc?
There was a problem hiding this comment.
Since it's done once per iteration, I think we can afford to just always go with the DeviceGuard. I couldn't make such assumptions in access_order.cc, but here it's quite different.
Alternatively, I can add an "record(cudaEvent_t)" function to AccessOrder - I'd rather not perpetuate the incidental complexity of stream handling in AccessOrder API.
There was a problem hiding this comment.
I always add DeviceGuard. It takes 80ns on my machine and that's done once per iteration, so it's rather cheap.
|
CI MESSAGE: [19826818]: BUILD STARTED |
|
CI MESSAGE: [19826818]: BUILD FAILED |
- refactor CachingList - use proper "item" wrapper type - remove "apprentice" and simplify lookahead logic - remove weird make_unique dependence - use r-value when recycling - refactor ExternalSource - store TensorList by value in list items - move all iteration data to one structure and queue - associate events directly with data items - use global event pool and obtain events for proper streams ---- Signed-off-by: Michal Zientkiewicz <[email protected]>
Signed-off-by: Michal Zientkiewicz <[email protected]>
Signed-off-by: Michal Zientkiewicz <[email protected]>
Signed-off-by: Michal Zientkiewicz <[email protected]>
mzient
force-pushed
the
external_source_refactoring_and_fixes
branch
from
c77478b
to
afc953e
Compare
Signed-off-by: Michał Zientkiewicz <[email protected]>
|
CI MESSAGE: [19867432]: BUILD STARTED |
|
CI MESSAGE: [19867432]: BUILD PASSED |
Category:
Bug fix (non-breaking change which fixes an issue)
Refactoring (Redesign of existing code that doesn't affect functionality)
Description:
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A