Dependency update 02/2025 #5801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Szymon Karpiński <[email protected]>
Signed-off-by: Szymon Karpiński <[email protected]>
This tag points to the same version as `boost-1.86.0` Signed-off-by: Szymon Karpiński <[email protected]>
Signed-off-by: Szymon Karpiński <[email protected]>
szkarpinski
commented
Feb 3, 2025
| @@ -7,11 +7,11 @@ This part of the repository contains extra dependencies required to build DALI, | |||
| +==================================================================+===========================================================================================================================+===================================================================================================================+ | |||
| | `Google Benchmark <https://github.com/google/benchmark>`_ | `1.9.1 <https://github.com/google/benchmark/releases/tag/v1.9.1>`_ | `Apache License 2.0 <https://github.com/google/benchmark/blob/master/LICENSE>`_ | | |||
| +------------------------------------------------------------------+---------------------------------------------------------------------------------------------------------------------------+-------------------------------------------------------------------------------------------------------------------+ | |||
| | `Boost Preprocessor <https://github.com/boostorg/preprocessor>`_ | `1.86.0 <https://github.com/boostorg/preprocessor/releases/tag/boost-1.86.0>`_ | `Boost Software License 1.0 <https://github.com/boostorg/boost/blob/master/LICENSE_1_0.txt>`_ | | |||
| | `Boost Preprocessor <https://github.com/boostorg/preprocessor>`_ | `1.87.0 <https://github.com/boostorg/preprocessor/releases/tag/boost-1.87.0>`_ | `Boost Software License 1.0 <https://github.com/boostorg/boost/blob/master/LICENSE_1_0.txt>`_ | | |||
There was a problem hiding this comment.
Tag 1.87.0 points to the same commit as 1.86.0 (see https://github.com/boostorg/preprocessor/tags), so this is just a cosmetic change.
Signed-off-by: Szymon Karpiński <[email protected]>
|
CI MESSAGE: [23435016]: BUILD STARTED |
|
CI MESSAGE: [23441741]: BUILD STARTED |
|
CI MESSAGE: [23435016]: BUILD PASSED |
|
CI MESSAGE: [23441741]: BUILD FAILED |
|
CI MESSAGE: [23441741]: BUILD PASSED |
stiepan
reviewed
Feb 5, 2025
| @@ -87,7 +87,7 @@ For more details please check the | |||
| # the latest astunparse (1.6.3) doesn't work with any other six than | |||
| # 1.16 on python 3.12 due to import six.moves | |||
| 'six >= 1.16, <= 1.16', | |||
| 'dm-tree <= 0.1.8', | |||
| 'dm-tree <= 0.1.9', | |||
There was a problem hiding this comment.
nit, we have those now in https://github.com/NVIDIA/DALI/blame/main/conda/dali_python_bindings/recipe/meta.yaml
too. Although, they seem to bound the version the other way round. :D
There was a problem hiding this comment.
That's right. Not sure why it's like that, but with >=0.1.8 they have already picked 0.1.9 even without my update
stiepan
approved these changes
Feb 5, 2025
banasraf
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
See also: NVIDIA/DALI_deps#127
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A
DALI-4168