Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant nvml::Shutdown from optical flow #5804

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Feb 3, 2025

Category:

Bug fix (non-breaking change which fixes an issue)

Description:

Additional information:

Affected modules and functionalities:

  • optical flow

Key points relevant for the review:

  • NA

Tests:

  • Existing tests apply
    • test_dali_variable_batch_size.test_optical_flow
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

- NVIDIA#5317 moved to scop based
  nvml init and shutdown, but a redundant shutdown has been
  left in the optical flow destructor. This PR removes it.

Signed-off-by: Janusz Lisiecki <[email protected]>
@JanuszL JanuszL added the important-fix Fixes an important issue in the software or development environment. label Feb 3, 2025
@JanuszL
Copy link
Contributor Author

JanuszL commented Feb 3, 2025

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [23397902]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [23397902]: BUILD FAILED

@JanuszL
Copy link
Contributor Author

JanuszL commented Feb 4, 2025

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [23427363]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [23427363]: BUILD PASSED

@JanuszL JanuszL merged commit 43874c2 into NVIDIA:main Feb 4, 2025
7 checks passed
@JanuszL JanuszL deleted the remove_nvml_shut branch February 4, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
important-fix Fixes an important issue in the software or development environment.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants